-
Notifications
You must be signed in to change notification settings - Fork 185
Windows support #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support #13
Conversation
* removal of lock files fixed
fixes #12 |
|
||
public class EmbeddedPostgres implements Closeable | ||
public class EmbeddedPostgres implements AutoCloseable, Closeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closeable
extends AutoCloseable
so this declaration is redundant, yeah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing
Thank you for the PR @MarekMalevic! I've left some comments, maybe take another pass at this? Then I'll do whatever final fixups are needed and merge it in. |
I have fixed most of the issues and added comments to those I agree with but would better keep them not to break backward compatibility on Mac. |
Thanks @MarekMalevic, I did the final bits and tested on Mac, could you please re-verify against Windows? If you are then satisfied with it, I can release 0.5.0 :) |
I have tested your updates on Windows 10 and it works. The sooner 0.5.0 is released, the better. We are eagerly waiting to use pg9.5.2 )) |
The latest version did not work for us on Windows 7 when run with administrator account:
|
This is postgres limitation, it shall not be started under root/admin . From this perspective IMO the tests that use this library should not run under super user account. |
I agree, tests do not care what user they run as -- if Postgres cannot run as admin, the tests will not run as admin, which I am totally okay with :) |
Releasing 0.5.0 now, should be in Maven Central within the hour @MarekMalevic |
Remove duplicated dependency (JUnit) from pom.xml
Removed dependency on uname (on Windows) and tar binaries.
Added 64 bit windows binary fetch to repack-postgres.sh script.
Tested on 64bit Windows 10.