Skip to content

Windows support #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 22, 2016
Merged

Windows support #13

merged 12 commits into from
Apr 22, 2016

Conversation

MarekMalevic
Copy link
Contributor

Removed dependency on uname (on Windows) and tar binaries.
Added 64 bit windows binary fetch to repack-postgres.sh script.
Tested on 64bit Windows 10.

@stevenschlansker
Copy link
Contributor

fixes #12


public class EmbeddedPostgres implements Closeable
public class EmbeddedPostgres implements AutoCloseable, Closeable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closeable extends AutoCloseable so this declaration is redundant, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing

@stevenschlansker
Copy link
Contributor

stevenschlansker commented Apr 22, 2016

Thank you for the PR @MarekMalevic! I've left some comments, maybe take another pass at this? Then I'll do whatever final fixups are needed and merge it in.

@MarekMalevic
Copy link
Contributor Author

I have fixed most of the issues and added comments to those I agree with but would better keep them not to break backward compatibility on Mac.

@stevenschlansker stevenschlansker merged commit ffb7ffd into opentable:master Apr 22, 2016
@stevenschlansker
Copy link
Contributor

Thanks @MarekMalevic, I did the final bits and tested on Mac, could you please re-verify against Windows? If you are then satisfied with it, I can release 0.5.0 :)

@MarekMalevic
Copy link
Contributor Author

I have tested your updates on Windows 10 and it works. The sooner 0.5.0 is released, the better. We are eagerly waiting to use pg9.5.2 ))

@soenkenils
Copy link

The latest version did not work for us on Windows 7 when run with administrator account:

The server must be started under an unprivileged user ID to prevent
possible system security compromises. See the documentation for
more information on how to properly start the server.

@MarekMalevic
Copy link
Contributor Author

This is postgres limitation, it shall not be started under root/admin . From this perspective IMO the tests that use this library should not run under super user account.

@stevenschlansker
Copy link
Contributor

I agree, tests do not care what user they run as -- if Postgres cannot run as admin, the tests will not run as admin, which I am totally okay with :)

@stevenschlansker
Copy link
Contributor

Releasing 0.5.0 now, should be in Maven Central within the hour @MarekMalevic
Thanks for the contribution!

cverges-medallia pushed a commit to cverges-medallia/otj-pg-embedded that referenced this pull request Dec 22, 2017
Remove duplicated dependency (JUnit) from pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants