Skip to content

test: add search e2e test case #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

test: add search e2e test case #2149

merged 1 commit into from
Jan 3, 2023

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Dec 30, 2022

Types

  • ⏱ Tests

Background or solution

新增如下测试:

  • 搜索文本后进行批量替换
  • 通过正则搜索内容
  • 进行区分大小写的内容搜索,能得到正确结果
  • 在编辑器中选中内容后,通过 CMD+SHIFT+F 可以在搜索面板进行快速搜索,正常展示搜索结果
  • 已删除的文件不会再次出现在搜索内容中
  • 点击搜索结果,在右侧编辑器展示响应内容
Kapture.2022-12-30.at.22.10.36.mp4

同时移除了搜索面板状态中冗余且无效的 isSearchFocus 状态存储,从根源处解决 #1203 问题。

#1475.

Changelog

add search e2e test case

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 57.78% // Head: 57.78% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d9a8af6) compared to base (f984ee6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
- Coverage   57.78%   57.78%   -0.01%     
==========================================
  Files        1313     1313              
  Lines       83001    82991      -10     
  Branches    17257    17253       -4     
==========================================
- Hits        47966    47960       -6     
+ Misses      31844    31839       -5     
- Partials     3191     3192       +1     
Flag Coverage Δ
jsdom 52.72% <ø> (-0.01%) ⬇️
node 16.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/search/src/browser/search.service.ts 49.76% <ø> (-0.13%) ⬇️
...ages/search/src/browser/tree/tree-model.service.ts 13.25% <ø> (+0.38%) ⬆️
packages/search/src/common/content-search.ts 67.08% <ø> (ø)
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️
...erences/src/browser/preference-settings.service.ts 76.41% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19
Copy link
Member Author

erha19 commented Dec 30, 2022

进一步追加了新的测试:

  • 搜索文本后进行批量替换
  • 已删除的文件不会再次出现在搜索内容中
  • 点击搜索结果,在右侧编辑器展示响应内容

@erha19 erha19 merged commit da970b0 into main Jan 3, 2023
@erha19 erha19 deleted the test/e2e/search branch January 3, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants