Skip to content

feat: Implementation of cross-end and cross-window file system service #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Sep 23, 2022

Conversation

songhn233
Copy link
Member

@songhn233 songhn233 commented Aug 29, 2022

Types

  • 🎉 New Features
  • 🐛 Bug Fixes

Background or solution

Related issue:

Close PR: #1384 分支乱了,新开一个(

Cross-window copy

Kapture.2022-07-20.at.01.54.23.mov

Cross-window drag and drop

Kapture.2022-07-20.at.01.24.30.mov

Electron

Kapture.2022-08-29.at.23.21.38.mov

Changelog

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Base: 57.68% // Head: 57.82% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (9737876) compared to base (0a645ff).
Patch coverage: 84.13% of modified lines in pull request are covered.

❗ Current head 9737876 differs from pull request most recent head 8829d3f. Consider uploading reports for the commit 8829d3f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
+ Coverage   57.68%   57.82%   +0.14%     
==========================================
  Files        1269     1256      -13     
  Lines       78950    78280     -670     
  Branches    16516    16378     -138     
==========================================
- Hits        45539    45268     -271     
+ Misses      30397    30048     -349     
+ Partials     3014     2964      -50     
Flag Coverage Δ
jsdom 52.63% <84.13%> (+0.11%) ⬆️
node 15.84% <11.03%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-common/src/electron.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...next/src/browser/services/file-tree-dnd.service.ts 69.19% <66.66%> (+11.35%) ⬆️
...browser/src/services/electron-clipboard.service.ts 81.57% <81.57%> (ø)
...xt/src/browser/services/file-tree-model.service.ts 52.97% <86.95%> (+1.06%) ⬆️
...ges/core-browser/src/services/clipboard.service.ts 66.10% <96.55%> (+27.39%) ⬆️
...ages/core-browser/src/bootstrap/inner-providers.ts 100.00% <100.00%> (ø)
packages/core-browser/src/services/index.ts 100.00% <100.00%> (ø)
packages/core-common/src/clipboard.ts 100.00% <100.00%> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 added this to the 2.21 milestone Sep 7, 2022
@songhn233 songhn233 marked this pull request as ready for review September 12, 2022 11:46
@songhn233 songhn233 changed the title WIP: Implementation of cross-end and cross-window file system service Implementation of cross-end and cross-window file system service Sep 12, 2022
@songhn233
Copy link
Member Author

Kapture.2022-09-12.at.02.32.57.mov

@songhn233
Copy link
Member Author

songhn233 commented Sep 12, 2022

native 与 opensumi 交互增强

file-tree drag to desktop

Kapture.2022-09-12.at.03.57.29.mov

只支持单个文件的拖拽,出于考虑文件内容不通过 file-service 读取,直接将 文件 uri 作为内容

看了下当前 node 没有提供 create url from file 的后端 api 服务,如果加上的话可以通过 url 进行下载完整内容

file-tree copy to desktop

浏览器:这个目前浏览器环境应该是做不到的,https://web.dev/async-clipboard
electronhttps://stackoverflow.com/questions/65264058/how-to-clip-file-into-clipboard-in-electron
看起来 electron 也不支持这种能力,vscode 也没有实现这一操作

@songhn233 songhn233 requested a review from erha19 September 12, 2022 17:18
@erha19 erha19 changed the title Implementation of cross-end and cross-window file system service feat: Implementation of cross-end and cross-window file system service Sep 13, 2022
@erha19
Copy link
Member

erha19 commented Sep 14, 2022

@songhn233 支持 Electron 或 Web 环境下 IDE 窗口间的文件拖拽"复制-粘贴"吗?

@songhn233
Copy link
Member Author

@songhn233 支持 Electron 或 Web 环境下 IDE 窗口间的文件拖拽"复制-粘贴"吗?

拖拽应该做的直接就是 move 操作了

@songhn233 songhn233 requested a review from erha19 September 20, 2022 19:11
@erha19 erha19 merged commit 6663c19 into opensumi:main Sep 23, 2022
@erha19 erha19 mentioned this pull request Oct 17, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants