Skip to content

feat: add @opensumi/playwright package #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 22, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 4, 2022

Types

  • 🎉 New Features
  • 🏗️ Build System

Background or solution

preview test:
image

Changelog

add @opensumi/playwright package

@erha19 erha19 added this to the 2.20 milestone Jul 6, 2022
@erha19 erha19 force-pushed the feat/add-opensumi-playwright branch from 0f7c406 to 38a5b09 Compare July 15, 2022 08:53
@erha19
Copy link
Member Author

erha19 commented Jul 15, 2022

支持了 Open View 的命令以及注册了对应 Command Palette ,以便后续 E2E 测试中快速打开对应视图界面

image

@erha19
Copy link
Member Author

erha19 commented Aug 4, 2022

新增如下测试案例及工具方法:

  1. 文件树中操作右键菜单,在目录下新建文件并新建文件夹
  2. 单击文件树文件情况下,编辑器以预览模式打开文件
  3. 双击文件树文件情况下,编辑器以固定模式打开文件
  4. 编辑器内修改文件后,编辑器 Tab 马上显示脏状态,保存后立即清楚脏状态
  5. 在文件树下复制文件路径和相对路径,并粘贴至编辑器保存(由于存在浏览器权限问题,会导致服务端 CI 过不去,目前跳过该测试用例)
  6. 在文件树下打开 editor2.js 文件,通过右键菜单打开 Go to Symbol... 功能,跳转至第二个 Symbol 后删除选中内容

预览效果:

Kapture.2022-08-04.at.23.44.40.mp4

@erha19 erha19 force-pushed the feat/add-opensumi-playwright branch from e6ddb95 to ef48535 Compare August 5, 2022 02:57
@erha19 erha19 force-pushed the feat/add-opensumi-playwright branch from 518a3ae to c85fddf Compare August 10, 2022 08:17
@erha19 erha19 force-pushed the feat/add-opensumi-playwright branch from 340fa8f to d0e3797 Compare August 10, 2022 08:44
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1263 (1ea26b4) into main (520fb8f) will decrease coverage by 0.02%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
- Coverage   57.90%   57.87%   -0.03%     
==========================================
  Files        1250     1251       +1     
  Lines       77916    77996      +80     
  Branches    16263    16275      +12     
==========================================
+ Hits        45115    45140      +25     
- Misses      29869    29918      +49     
- Partials     2932     2938       +6     
Flag Coverage Δ
jsdom 52.52% <55.55%> (-0.04%) ⬇️
node 15.91% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/extension/src/browser/vscode/builtin-commands.ts 100.00% <ø> (ø)
packages/extension/src/hosted/ext.process-base.ts 0.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...-layout/src/browser/accordion/accordion.service.ts 65.60% <ø> (ø)
packages/main-layout/src/browser/layout.service.ts 63.23% <0.00%> (-0.47%) ⬇️
...s/main-layout/src/common/main-layout.defination.ts 100.00% <ø> (ø)
packages/quick-open/src/common/index.ts 100.00% <ø> (ø)
...-next/src/browser/contribution/terminal.command.ts 0.00% <ø> (ø)
...xt/src/browser/contribution/terminal.keybinding.ts 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@erha19 erha19 force-pushed the feat/add-opensumi-playwright branch from 4a3f631 to e55f5ae Compare August 11, 2022 03:41
@erha19 erha19 mentioned this pull request Aug 15, 2022
36 tasks
@erha19
Copy link
Member Author

erha19 commented Aug 18, 2022

bytemain
bytemain previously approved these changes Aug 18, 2022
@erha19
Copy link
Member Author

erha19 commented Aug 19, 2022

修改相应的 Breaking Change 文档如下:问题/输出面板 ContainerID 修改

@erha19 erha19 merged commit c26945d into main Aug 22, 2022
@erha19 erha19 deleted the feat/add-opensumi-playwright branch August 22, 2022 03:37
songhn233 pushed a commit to songhn233/opensumi that referenced this pull request Aug 23, 2022
* feat: add @opensumi/playwright package

* feat: add view containers id into elements

* feat: add quick command palette handler and rename testname

* feat: support open view command and command palette

* test: support open any view anytime

* chore: support debug current playwright test

* feat: support custom workspace files with the test

* feat: support calling context menu on anywhere

* chore: skip copy/paste case cause the permission issue

* test: open file without preview mode

* chore: waiting for goto symbol

* chore: resolve fix error

* chore: fix test error

* chore: add e2e github action

* chore: update e2e.yml

* chore: ignore playwright lib for eslint

* chore: add logger mock

* chore: add parallel execution

* chore: use ubuntu-20.04

* chore: move some deps to devDependences

* chore: use other playwright action

* chore: run init & test

* chore: fix test command

* chore: add extension download script

* chore: add template folder for test

* chore: add miniSize property

* chore: support clipboard api test

* chore: upload test results

* chore: not use headless test

* chore: update report result

* chore: fix typo
@erha19 erha19 mentioned this pull request Aug 24, 2022
1 task
erha19 added a commit that referenced this pull request Aug 25, 2022
* refactor: archiver & yauzl -> compressing

* chore: clear package.json config

* refactor(script): download unzip with compressing

* chore: clear package.json config

* refactor: review issue fix

* chore: comment format

* chore: clear misc

* chore: remove type assertion

* fix: update test

* refactor: archiver & yauzl -> compressing

* chore: clear package.json config

* refactor(script): download unzip with compressing

* chore: clear package.json config

* refactor: review issue fix

* chore: comment format

* chore: clear misc

* chore: remove type assertion

* feat: shortcut-adaptation-of-alt+0 (#1540)

* feat: shortcut adaptation of alt+9 (#1544)

* fix: toolbar action button not middle (#1543)

* fix: terminal contextmenu prevent default (#1545)

* fix: diff editor previous/next  mouse position (#1555)

* feat: add @opensumi/playwright package (#1263)

* feat: add @opensumi/playwright package

* feat: add view containers id into elements

* feat: add quick command palette handler and rename testname

* feat: support open view command and command palette

* test: support open any view anytime

* chore: support debug current playwright test

* feat: support custom workspace files with the test

* feat: support calling context menu on anywhere

* chore: skip copy/paste case cause the permission issue

* test: open file without preview mode

* chore: waiting for goto symbol

* chore: resolve fix error

* chore: fix test error

* chore: add e2e github action

* chore: update e2e.yml

* chore: ignore playwright lib for eslint

* chore: add logger mock

* chore: add parallel execution

* chore: use ubuntu-20.04

* chore: move some deps to devDependences

* chore: use other playwright action

* chore: run init & test

* chore: fix test command

* chore: add extension download script

* chore: add template folder for test

* chore: add miniSize property

* chore: support clipboard api test

* chore: upload test results

* chore: not use headless test

* chore: update report result

* chore: fix typo

* fix: dirty count calculate mistake (#1550)

* fix: editor title menu should always worked (#1549)

* fix: cancel long time save operator (#1554)

* v2.19.9

* fix: update test

* fix: update test

* chore: update compressing version

Co-authored-by: Dan <[email protected]>
Co-authored-by: iamxukai <[email protected]>
Co-authored-by: John <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants