Inline SVGs with inline_svg gem #5938
Merged
+136
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want both optimizing svg by micromanaging their attributes and externalizing them as effectively "binary" data? How is that supposed to work at the same time? |
This comment was marked as off-topic.
This comment was marked as off-topic.
hlfan
force-pushed
the
outline-svg
branch
2 times, most recently
from
1c49715 to
f637c55
Compare
hlfan
force-pushed
the
outline-svg
branch
2 times, most recently
from
13c45a4 to
08895a3
Compare
hlfan
force-pushed
the
outline-svg
branch
2 times, most recently
from
30bda22 to
08f39f5
Compare
hlfan
force-pushed
the
outline-svg
branch
6 times, most recently
from
b8f12cf to
8c11362
Compare
hlfan
force-pushed
the
outline-svg
branch
8 times, most recently
from
0a24a2e to
d53da02
Compare
hlfan
force-pushed
the
outline-svg
branch
3 times, most recently
from
a3b34e1 to
4b26e74
Compare
|
Looks good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the inline_svg gem, this PR resolves #5880.
How has this been tested?
Verifying that the local Rails output matches