Skip to content

Remove right sidebar, use left sidebar for map key, layers, share #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/abilities/ability.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ def initialize(user)
:changeset, :query], :browse
can [:show, :new], Note
can :search, :direction
can [:index, :permalink, :edit, :help, :fixthemap, :offline, :export, :about, :communities, :preview, :copyright, :key, :id], :site
can [:index, :permalink, :edit, :help, :fixthemap, :offline, :export, :about, :communities, :preview, :copyright, :key, :id,
:mapkey, :layers, :share], :site
can [:finish, :embed], :export
can [:search, :search_latlon, :search_osm_nominatim, :search_osm_nominatim_reverse], :geocoder
can [:token, :request_token, :access_token, :test_request], :oauth
Expand Down
40 changes: 12 additions & 28 deletions app/assets/javascripts/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//= require_self
//= require leaflet.sidebar
//= require leaflet.sidebar-pane
//= require leaflet.locatecontrol/src/L.Control.Locate
//= require leaflet.locate
//= require leaflet.layers
Expand All @@ -21,6 +19,9 @@
//= require index/directions
//= require index/changeset
//= require index/query
//= require index/mapkey
//= require index/layers
//= require index/share
//= require router
//= require qs/dist/qs

Expand Down Expand Up @@ -99,9 +100,6 @@ $(document).ready(function () {
}
});

var sidebar = L.OSM.sidebar("#map-ui")
.addTo(map);

var position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";

function addControlGroup(controls) {
Expand All @@ -124,34 +122,17 @@ $(document).ready(function () {
]);

addControlGroup([
L.OSM.layers({
position: position,
layers: map.baseLayers,
sidebar: sidebar
}),
L.OSM.key({
position: position,
sidebar: sidebar
}),
L.OSM.share({
"position": position,
"sidebar": sidebar,
"short": true
})
L.OSM.layers({ position: position }),
L.OSM.key({ position: position }),
L.OSM.share({ position: position })
]);

addControlGroup([
L.OSM.note({
position: position,
sidebar: sidebar
})
L.OSM.note({ position: position })
]);

addControlGroup([
L.OSM.query({
position: position,
sidebar: sidebar
})
L.OSM.query({ position: position })
]);

L.control.scale()
Expand Down Expand Up @@ -376,7 +357,10 @@ $(document).ready(function () {
"/way/:id(/history)": OSM.Browse(map, "way"),
"/relation/:id(/history)": OSM.Browse(map, "relation"),
"/changeset/:id": OSM.Changeset(map),
"/query": OSM.Query(map)
"/query": OSM.Query(map),
"/mapkey": OSM.MapKey(map),
"/layers": OSM.Layers(map),
"/share": OSM.Share(map)
});

if (OSM.preferred_editor === "remote" && document.location.pathname === "/edit") {
Expand Down
192 changes: 192 additions & 0 deletions app/assets/javascripts/index/layers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
OSM.Layers = function (map) {
var page = {},
layersButton = $(".control-layers .control-button"),
layers = map.baseLayers,
miniMaps = [],
baseLayerSwitchListeners = [];

layersButton.on("click", function (e) {
e.preventDefault();
e.stopPropagation();

OSM.router.route("/layers");
});

function setViewOfMiniMaps(options) {
miniMaps.forEach(function (miniMap) {
miniMap.setView(map.getCenter(), Math.max(map.getZoom() - 2, 0), options);
});
}

function initMiniMaps() {
miniMaps.forEach(function (miniMap) {
miniMap.invalidateSize();
});
setViewOfMiniMaps({ animate: false });
}

function updateMiniMaps() {
setViewOfMiniMaps();
}

function toggleDisableOverlayCheckbox(item, disabled) {
var input = item.find("input");
input.prop("disabled", disabled);

if (disabled && input.prop("checked")) {
input
.prop("checked", false)
.data("checked", true)
.trigger("change");
} else if (!disabled && input.data("checked")) {
input
.prop("checked", true)
.removeData("checked")
.trigger("change");
}

item
.attr("class", disabled ? "disabled" : "")
.tooltip(disabled ? "enable" : "disable");
}

function updateDisableOverlayCheckboxes() {
toggleDisableOverlayCheckbox(
$("#layers_contents .overlay-layers ul li[data-name=notes]"),
map.getBounds().getSize() >= OSM.MAX_NOTE_REQUEST_AREA
);
toggleDisableOverlayCheckbox(
$("#layers_contents .overlay-layers ul li[data-name=data]"),
map.getBounds().getSize() >= OSM.MAX_REQUEST_AREA
);
}

function updateCheckOverlayCheckboxes() {
$("#layers_contents .overlay-layers ul li[data-name=notes] input")
.prop("checked", map.hasLayer(map.noteLayer));
$("#layers_contents .overlay-layers ul li[data-name=data] input")
.prop("checked", map.hasLayer(map.dataLayer));
$("#layers_contents .overlay-layers ul li[data-name=gps] input")
.prop("checked", map.hasLayer(map.gpsLayer));
}

page.pushstate = page.popstate = function (path) {
OSM.loadSidebarContent(path, page.load);
};

page.load = function () {
layersButton.addClass("active");

var baseLayers = $("#layers_contents .base-layers ul");

layers.forEach(function (layer) {
var item = $("<li>")
.attr("class", "rounded-3")
.appendTo(baseLayers);

if (map.hasLayer(layer)) {
item.addClass("active");
}

var div = $("<div>")
.appendTo(item);

var miniMap = L.map(div[0], { attributionControl: false, zoomControl: false, keyboard: false })
.addLayer(new layer.constructor({ apikey: layer.options.apikey }));

miniMap.dragging.disable();
miniMap.touchZoom.disable();
miniMap.doubleClickZoom.disable();
miniMap.scrollWheelZoom.disable();

miniMaps.push(miniMap);

var label = $("<label>")
.appendTo(item);

var input = $("<input>")
.attr("type", "radio")
.prop("checked", map.hasLayer(layer))
.appendTo(label);

label.append(layer.options.name);

item.on("click", function () {
layers.forEach(function (other) {
if (other === layer) {
map.addLayer(other);
} else {
map.removeLayer(other);
}
});
map.fire("baselayerchange", { layer: layer });
});

item.on("dblclick", function () {
OSM.router.route("/" + OSM.formatHash(map));
});

var baseLayerSwitchListener = function () {
item.toggleClass("active", map.hasLayer(layer));
input.prop("checked", map.hasLayer(layer));
};
baseLayerSwitchListeners.push(baseLayerSwitchListener);
map.on("layeradd layerremove", baseLayerSwitchListener);
});

map.whenReady(initMiniMaps);
map.on("moveend", updateMiniMaps);

if (OSM.STATUS !== "api_offline" && OSM.STATUS !== "database_offline") {
$("#layers_contents .overlay-layers ul li input").on("change", function () {
var checked = $(this).prop("checked"),
name = $(this).closest("li").attr("data-name"),
layer;

if (name === "notes") {
layer = map.noteLayer;
} else if (name === "data") {
layer = map.dataLayer;
} else if (name === "gps") {
layer = map.gpsLayer;
}

if (layer) {
if (checked) {
map.addLayer(layer);
} else {
map.removeLayer(layer);
}
map.fire("overlaylayerchange", { layer: layer });
}
});

map.on("zoomend", updateDisableOverlayCheckboxes);
updateDisableOverlayCheckboxes();

map.on("layeradd layerremove", updateCheckOverlayCheckboxes);
updateCheckOverlayCheckboxes();
}
};

page.unload = function () {
if (OSM.STATUS !== "api_offline" && OSM.STATUS !== "database_offline") {
map.off("layeradd layerremove", updateCheckOverlayCheckboxes);
map.off("zoomend", updateDisableOverlayCheckboxes);
}
map.off("moveend", updateMiniMaps);
map.off("load", initMiniMaps);

baseLayerSwitchListeners.forEach(function (baseLayerSwitchListener) {
map.off("layeradd layerremove", baseLayerSwitchListener);
});
baseLayerSwitchListeners = [];
miniMaps.forEach(function (miniMap) {
miniMap.remove();
});
miniMaps = [];
layersButton.removeClass("active");
};

return page;
};
44 changes: 44 additions & 0 deletions app/assets/javascripts/index/mapkey.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
OSM.MapKey = function (map) {
var page = {},
mapKeyButton = $(".control-key .control-button");

mapKeyButton.on("click", function (e) {
e.preventDefault();
e.stopPropagation();

if ($(this).hasClass("disabled")) return;

OSM.router.route("/mapkey");
});

function update() {
var layer = map.getMapBaseLayerId(),
zoom = map.getZoom();

$(".mapkey-table-entry").each(function () {
var data = $(this).data();
$(this).toggle(
layer === data.layer &&
(!data.zoomMin || zoom >= data.zoomMin) &&
(!data.zoomMax || zoom <= data.zoomMax)
);
});
}

page.pushstate = page.popstate = function (path) {
OSM.loadSidebarContent(path, page.load);
};

page.load = function () {
mapKeyButton.addClass("active");
map.on("zoomend baselayerchange", update);
$("#mapkey_contents").load("/key", update);
};

page.unload = function () {
map.off("zoomend baselayerchange", update);
mapKeyButton.removeClass("active");
};

return page;
};
Loading