Skip to content

Docs/Governance: Add closing of abandoned PRs to responsibilities of the the triage role #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2025

Conversation

matkoniecz
Copy link
Collaborator

@matkoniecz matkoniecz commented Jun 16, 2025

Description, Motivation & Context

I think it would make sense for Triage role to be allowed to close PRs which got abandoned. Or duplicated ones.

Note: it is already technically possible for them to do, they have "close" button active also on PRs.

Note: it is deliberate that "I think that this tagging idea is terrible" is omitted as reason for PR closing here.

Disclaimer: I just got triage role.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and is also something I'd expect from the "triage" role. What do you think @tordans, @k-yle?

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

as it applies not to triage role
@matkoniecz matkoniecz changed the title alllow Triage Role to "Closing abandoned, duplicated or invalid PRs." alllow Triage Role to "Closing abandoned, duplicated or invalid PRs.", encourage to ping authors first before closing their PRs/issues Jun 16, 2025
@tyrasd tyrasd added the documentation Improvements or additions to documentation label Jun 16, 2025
@matkoniecz
Copy link
Collaborator Author

Note: it is deliberate that "I think that this tagging idea is terrible" is omitted as reason for PR closing here.

I am also willing to be convinced on including this as valid reason for PR closing for people in triage role. Unsure whether it should be done this way or not.

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition.
Here is one unrelated change suggestion – to update the docs to our current stack.
And one related change suggestion – to keep the wording of the paragraphs more similar in the way the are worded and structured.

@tordans
Copy link
Collaborator

tordans commented Jun 27, 2025

@matkoniecz are you happy with my suggested changes? If so I think we could merge this…

matkoniecz and others added 2 commits June 28, 2025 05:42
@matkoniecz
Copy link
Collaborator Author

I merged subPRs

@tordans tordans changed the title alllow Triage Role to "Closing abandoned, duplicated or invalid PRs.", encourage to ping authors first before closing their PRs/issues Docs/Governance: Add closing of abandoned PRs to responsibilities of the the triage role Jun 28, 2025
@tordans tordans merged commit c3e2fad into openstreetmap:main Jun 28, 2025
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Jun 28, 2025

@matkoniecz thanks. Btw, what role do you yourself have now. Could you create a PR to add you to the docs?

@matkoniecz
Copy link
Collaborator Author

@tordans 65f7c41

@matkoniecz matkoniecz deleted the patch-10 branch June 28, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants