-
Notifications
You must be signed in to change notification settings - Fork 199
Docs/Governance: Add closing of abandoned PRs to responsibilities of the the triage role #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
as it applies not to triage role
I am also willing to be convinced on including this as valid reason for PR closing for people in triage role. Unsure whether it should be done this way or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good addition.
Here is one unrelated change suggestion – to update the docs to our current stack.
And one related change suggestion – to keep the wording of the paragraphs more similar in the way the are worded and structured.
@matkoniecz are you happy with my suggested changes? If so I think we could merge this… |
Co-authored-by: Tobias <[email protected]>
Co-authored-by: Tobias <[email protected]>
I merged subPRs |
@matkoniecz thanks. Btw, what role do you yourself have now. Could you create a PR to add you to the docs? |
Description, Motivation & Context
I think it would make sense for Triage role to be allowed to close PRs which got abandoned. Or duplicated ones.
Note: it is already technically possible for them to do, they have "close" button active also on PRs.
Note: it is deliberate that "I think that this tagging idea is terrible" is omitted as reason for PR closing here.
Disclaimer: I just got triage role.