-
Notifications
You must be signed in to change notification settings - Fork 199
Add preset for memorial=blue_plaque
#1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Something fails with the build. Did not see what right away. Do we want name and or inscription on those? |
Signed-off-by: Harry Bond <[email protected]>
ah, bad commas 👍 have added |
Preview is now generating. Could you add the test documentation that is liked in the PR template and preview comment. |
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
added test documentation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I changed the tags<>addTags setup a bit (see hidden comment).
Description, Motivation & Context
resolves streetcomplete/StreetComplete#6342 (comment)
Related issues
streetcomplete/StreetComplete#6342 (comment)
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Test-Documentation
Preview links & Sidebar Screenshots
https://pr-1601--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.51/51.47838/-0.00689&disable_features=boundaries&background=Bing&id=n7985753879
Search
Info-
i
Wording
name
,aliases
(if present) use Title Caseterms
(if present) use lower case, sorted A-Z