Skip to content

Add preset for memorial=blue_plaque #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Conversation

hb0nd
Copy link
Contributor

@hb0nd hb0nd commented Jun 13, 2025

Description, Motivation & Context

resolves streetcomplete/StreetComplete#6342 (comment)

Related issues

streetcomplete/StreetComplete#6342 (comment)

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

https://taginfo.openstreetmap.org/tags/memorial%3Dblue_plaque

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1601--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.51/51.47838/-0.00689&disable_features=boundaries&background=Bing&id=n7985753879

image1-6

Search

image1-2

Info-i

image

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tordans
Copy link
Collaborator

tordans commented Jun 13, 2025

Something fails with the build. Did not see what right away.

Do we want name and or inscription on those?

@hb0nd
Copy link
Contributor Author

hb0nd commented Jun 13, 2025

ah, bad commas 👍 have added name and inscription, moved subject:wikidata to fields, and moved direction to moreFields

@hb0nd hb0nd requested a review from tordans June 13, 2025 18:34
@tordans
Copy link
Collaborator

tordans commented Jun 15, 2025

Preview is now generating. Could you add the test documentation that is liked in the PR template and preview comment.
Not to sef: https://overpass-turbo.eu/s/267r

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@hb0nd
Copy link
Contributor Author

hb0nd commented Jun 16, 2025

added test documentation :)

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I changed the tags<>addTags setup a bit (see hidden comment).

@tordans tordans added the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Jun 17, 2025
@tordans tordans merged commit c91ebf6 into openstreetmap:main Jun 24, 2025
1 check passed
@hb0nd hb0nd deleted the blue_plaque branch June 24, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-preset regional waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blue Plaque described as memorial
2 participants