Skip to content

Add preset for climbing=area #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025
Merged

Conversation

harahu
Copy link
Contributor

@harahu harahu commented Jun 12, 2025

Description, Motivation & Context

This PR is part of a larger effort to add support for rock climbing related features to iD. In this PR we add a preset for a climbing "area", which is understood to be a grouping of distinct crags that in the immediate vicinity of each other. Often an area will be delimited by a climbing guide book, where the OSM area will correspond to the area covered by the book. This might seem arbitrary, but never the less it matches closely with how climbers think about and use climbing related geodata in practice. Climbing areas are currently in active use by data consumers, e.g. openclimbing.org.

Climbing areas can be equipped with additional fields, in addition to a name. Usually this would be tags representing summary statistics for the routes and crags contained within the area. I've consciously decided to leave such fields out of this PR, since in practice all this information can be computed from the member objects. If it is decided at a later point that we want to encourage such tagging, we can always expand the preset then.

I've set up a Wikibase entry and a corresponding article for climbing areas, which can be found here:
https://wiki.openstreetmap.org/wiki/Item:Q23045
https://wiki.openstreetmap.org/wiki/Tag:climbing%3Darea

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/tags/climbing=area
https://taghistory.raifer.tech/#***/climbing/area

677 current uses

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@harahu
Copy link
Contributor Author

harahu commented Jun 12, 2025

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1596--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.03/59.90399/5.91897&disable_features=boundaries&background=geovekst-nib&id=r19136912
Screenshot 2025-06-12 at 09 47 18
Screenshot 2025-06-12 at 09 49 42

Search

Screenshot 2025-06-12 at 09 52 33

Info-i

Screenshot 2025-06-12 at 13 13 29

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@harahu harahu mentioned this pull request Jun 13, 2025
@tordans tordans added the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Jun 15, 2025
@tordans tordans merged commit da500ee into openstreetmap:main Jun 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-field waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants