-
Notifications
You must be signed in to change notification settings - Fork 199
Add "Suitable For Dogs" field to amenity=drinking_water
preset
#1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dog field which is https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/dog.json is not the right field for this I think. The options are wrong.
I am also not sure about the options. The wiki has designated and yes. But why this distinction is made is unclear IMO. Why not use yes always?
A more general question is: Do we want to add this. I see 2k usage in combination with drinking water in https://taginfo.openstreetmap.org/tags/amenity%3Ddrinking_water#combinations
That would be enough for our (flexible) threshold to add the field.
Lets wait for other feedback and see how we can create a working field for this.
Is the bowl for dogs only? |
When I've been mapping drinking water with a dog bowl, I use
Good question, below is an example of drinking water with a bowl. I've never encountered a sign saying the bowl is only for dogs. |
I think |
Look at key:dog it states:
|
If we want to add this, we should add a special checkbox field (yes/no/nil) with a label similar to „dogs can dring here“. |
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
I've changed it so that dog is now a checkbox |
Could someone link a few examples and check https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L38-L69 to make reviewing this quicker? Thanks |
Test-DocumentationPreview links & Sidebar ScreenshotsInfo-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now.
The check
type is not perfect, IMO, because it promotes dog=no
a little more that I think is ideal. But given this is a moreFields
I don't think this will become an issue and its also not wrong…
I think we should change the label a bit.
Co-authored-by: Tobias <[email protected]>
amenity=drinking_water
preset
Description, Motivation & Context
Based on my surveying in the UK and Australia, it's quite common for drinking water to have facilities for dogs by way of a dedicated dog bowl.
Links and data
Relevant OSM Wiki links:
amenity=drinking_water
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.