Skip to content

Add "Suitable For Dogs" field to amenity=drinking_water preset #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025

Conversation

codeinabox
Copy link
Contributor

Description, Motivation & Context

Based on my surveying in the UK and Australia, it's quite common for drinking water to have facilities for dogs by way of a dedicated dog bowl.

Links and data

Relevant OSM Wiki links:
amenity=drinking_water

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dog field which is https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/dog.json is not the right field for this I think. The options are wrong.

I am also not sure about the options. The wiki has designated and yes. But why this distinction is made is unclear IMO. Why not use yes always?

A more general question is: Do we want to add this. I see 2k usage in combination with drinking water in https://taginfo.openstreetmap.org/tags/amenity%3Ddrinking_water#combinations
That would be enough for our (flexible) threshold to add the field.


Lets wait for other feedback and see how we can create a working field for this.

@tordans tordans added new-field waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels Jun 4, 2025
@novolife
Copy link
Contributor

novolife commented Jun 4, 2025

Is the bowl for dogs only?

@codeinabox
Copy link
Contributor Author

I am also not sure about the options. The wiki has designated and yes. But why this distinction is made is unclear IMO. Why not use yes always?

When I've been mapping drinking water with a dog bowl, I use dog=yes. Would designated mean the drinking water is only for dogs?

Is the bowl for dogs only?

Good question, below is an example of drinking water with a bowl. I've never encountered a sign saying the bowl is only for dogs.

20230101_DrinkingWater_WaterFountain

@novolife
Copy link
Contributor

novolife commented Jun 4, 2025

I think pets_allowed=* might be better? Nobody uses that one though.

@codeinabox
Copy link
Contributor Author

I think pets_allowed=* might be better? Nobody uses that one though.

Look at key:dog it states:

To clarify that an amenity is suitable or intended for dogs, dog=yes may be added.

dog=yes makes the most sense to me, and it's how I've been tagging drinking water with a dog bowl.

@tordans
Copy link
Collaborator

tordans commented Jun 4, 2025

If we want to add this, we should add a special checkbox field (yes/no/nil) with a label similar to „dogs can dring here“.

Copy link

github-actions bot commented Jun 4, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@codeinabox codeinabox marked this pull request as draft June 5, 2025 08:34
@codeinabox
Copy link
Contributor Author

I've changed it so that dog is now a checkbox

@codeinabox codeinabox requested a review from tordans June 5, 2025 08:55
@tordans
Copy link
Collaborator

tordans commented Jun 6, 2025

Could someone link a few examples and check https://github.com/openstreetmap/id-tagging-schema/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L38-L69 to make reviewing this quicker? Thanks

@tordans tordans marked this pull request as ready for review June 6, 2025 08:26
@novolife
Copy link
Contributor

novolife commented Jun 7, 2025

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1584--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.80/51.33939/12.38144&disable_features=boundaries&background=Bing&id=n11920278197

ss1

ss3

ss4

Info-i

ss2

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.
The check type is not perfect, IMO, because it promotes dog=no a little more that I think is ideal. But given this is a moreFields I don't think this will become an issue and its also not wrong…

I think we should change the label a bit.

@codeinabox codeinabox requested a review from tordans June 9, 2025 09:53
@tordans tordans added waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. and removed waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on labels Jun 9, 2025
@tordans tordans changed the title Add dog field to drinking water preset Add "Suitable For Dogs" field to amenity=drinking_water preset Jun 9, 2025
@tordans tordans merged commit 8b93d18 into openstreetmap:main Jun 9, 2025
5 checks passed
@tordans tordans removed the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Jun 9, 2025
@codeinabox codeinabox deleted the drinking-water-dog branch June 9, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants