Skip to content

Add terms to amenity=toilets preset #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

matkoniecz
Copy link
Collaborator

Description, Motivation & Context

screen-2025-06-03-09-23-45

Related issues

I am using https://wiki.openstreetmap.org/wiki/Overture_categories and https://codeberg.org/matkoniecz/detect-missing-search-terms-in-id-presets to find some missing search terms

excerpt from some know unreviewed terms

womens clothing store
womens_clothing_store

hat shop
hat_shop

leather good
leather goods
leather_goods

saree shop
saree_shop

sleepwear
sleepwear

used vintage and consignment
used_vintage_and_consignment

handbag store
handbag stores
handbag_stores

orthopedic shoe store
orthopedic_shoe_store

cosmetic and beauty supplie
cosmetic and beauty supplies
cosmetic_and_beauty_supplies

hair supply store
hair supply stores
hair_supply_stores

eyewear and optician
eyewear_and_optician

sunglasses store
sunglasses_store

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dtoilets - mentions also "lavatory", maybe it also should be included?

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

github-actions bot commented Jun 3, 2025

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@tordans tordans added the new-label changes the name, aliases or terms of a preset label Jun 4, 2025
@tordans tordans changed the title make toilets more findable Add terms to amenity=toilets preset Jun 4, 2025
@tordans tordans merged commit 4ab2240 into openstreetmap:main Jun 4, 2025
5 checks passed
@matkoniecz matkoniecz deleted the patch-10 branch June 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants