Skip to content

Add direction field to Observation Tower preset #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

zbycz
Copy link
Contributor

@zbycz zbycz commented May 28, 2025

Description, Motivation & Context

It is useful to know which direction the observation tower looks. The field already exists.

tower:type=observation
direction=*

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@zbycz
Copy link
Contributor Author

zbycz commented May 29, 2025

Test-Documentation

Preview links & Sidebar Screenshots

example link screenshot
many tags
few tags

Search

N/A - only field

Info-i

N/A - not adding a new field, but it works fine.

Wording

N/A

@andrewharvey
Copy link
Contributor

looks good

@tordans tordans changed the title add direction field to man_made/tower/observation Add direction field to Observation Tower May 30, 2025
@tordans tordans changed the title Add direction field to Observation Tower Add direction field to Observation Tower preset May 30, 2025
Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder if we should wait until openstreetmap/iD#11076 was fixed because I image the 0-360 value to be common and we don't want this to be removed by accident.

@tordans tordans added the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label May 30, 2025
@tordans tordans merged commit 4660204 into openstreetmap:main Jun 4, 2025
5 checks passed
@tordans tordans removed the waiting-ready-to-merge Ready to merge, but let's wait a few days for possible feedback. label Jun 4, 2025
@zbycz zbycz deleted the patch-1 branch June 4, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants