Add historic=aircraft Preset

[novolife]

Description, Motivation & Context

Historic Aircraft is common

Related issues

Closes #1512

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag%3Ahistoric%3Daircraft

Relevant tag usage stats:
5,846

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

1. After you submit your PR, the system will create a preview and comment on your PR:

   🍱 You can preview the tagging presets of this pull request here.
   If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

2. Once the preview is ready, use it to test your changes.

3. Now copy the snippet below into a new comment and fill out the blanks.

4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

[tordans]

This looks good at first glance. Right now the preview does not build due to the missing comma.
Update: I just fixed that myself.

Please add the testing documentation next for the next review.

[novolife]

@tordans

🔬  Validating schema...
Unknown preset field "aircraft:type" in "fields" array of preset "historic/aircraft" (undefined) 

This happens in the build preview, can you help me check what's causing it?

[tordans]

I think this is what causes the errors; will try it right away.

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[novolife]

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1556--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466

Search

Info-i

Wording

• American English
• name, aliases (if present) use Title Case
• terms (if present) use lower case, sorted A-Z

[kjonosm]

@tordans Trying to translate all the different keys and values within this preset I wonder how it passed the threshold newly set out in the guidelines regarding established and/or documented tags and values.

• the used key aircraft:model=* contradicts the key model=* as suggested in the osm wiki
• the used key aircraft:model:wikidata=* contradicts the key model:wikidata=* as suggested in the osm wiki
• the used values for aircraft:type=* seem "documented" only by a taglist collection that seems rather random

I am not opposing the preset but would recommend to remove the above mentioned additional tags.

[tordans]

@novolife could you look into the feedback above for a follow up?

[novolife]

I did make some mistakes with those three tags. I agree to remove the aircraft:model related field and replace it with model. As for aircraft:type, I don't have any other ideas other than changing it to semiCombo.