Skip to content

Create teahouse preset #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Create teahouse preset #1555

merged 2 commits into from
May 23, 2025

Conversation

novolife
Copy link
Contributor

Description, Motivation & Context

Teahouse is common in UK, East Asia and Southeast Asia.

Related issues

Closes #1522

Links and data

Relevant OSM Wiki links:
Tea

Relevant tag usage stats:
1,810

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife
Copy link
Contributor Author

novolife commented May 22, 2025

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1555--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.60/14.65605/121.06291&disable_features=boundaries&background=Bing&id=n-1

ss_1

ss_2

Search

ss_4

Info-i

ss_3

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except for the info-i part (see comment).

@novolife
Copy link
Contributor Author

This looks good to me, except for the info-i part (see comment).

ss_4

@tordans tordans merged commit caebe1a into openstreetmap:main May 23, 2025
5 checks passed
@novolife novolife deleted the teahouse branch May 23, 2025 14:03
@simonpoole
Copy link

This looks good to me, except for the info-i part (see comment).

Well seems the fact that https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dteahouse exists didn't seem to turn up. I would note that the wiki pages both for cuisine=tea and cuisine=teahouse were created by the same editor.

@tordans
Copy link
Collaborator

tordans commented May 28, 2025

@simonpoole
Copy link

There wasn't any reasoning why to prefer one value over the other or even a mention that the other value existed and was in use.

@tordans
Copy link
Collaborator

tordans commented Jun 3, 2025

@novolife what is your take on this?

  • cuisine=teahouse has ~300 usage; documented sind 2021
  • cuisine=tea has ~900 usage; documented since 2023 but basically a stub

cuisine=tea is not listed as a synonym on cuisine=teahouse.

Is tea a synonym for teahouse? Why should we pick the one over the other?
And where did you find the usage of ~1.800 from your issue and PR description? https://taginfo.openstreetmap.org/tags/cuisine%3Dteahouse

@novolife
Copy link
Contributor Author

novolife commented Jun 3, 2025

And where did you find the usage of ~1.800 from your issue and PR description?

I mistakenly added up the numbers for all/node/way.

Is tea a synonym for teahouse? Why should we pick the one over the other?

When I posted the issue #1522 , I didn't find cuisine=teahouse on Key:cuisine or in the Tea, and Tea mentions that "amenity=cafe + cuisine=tea – A café that mainly serves tea.", most people would think that this is what a teahouse is, so I thought this tagging scheme was quite natural, especially since bubble tea is tagged the same way.

As for why I couldn't find it, it can only be attributed to the fact that this tag is not so commonly used and, like cuisine=coffee_shop, is counterintuitive.

@tordans
Copy link
Collaborator

tordans commented Jun 3, 2025

@novolife thanks for checking again. I accidentally misread the data and confused what we are using here. I think this is all good as is.

I added the "possible synonyms" to the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Teahouse' Preset
3 participants