-
Notifications
You must be signed in to change notification settings - Fork 199
Create teahouse preset #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create teahouse preset #1555
Conversation
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar ScreenshotsSearchInfo-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, except for the info-i part (see comment).
Co-authored-by: Tobias <[email protected]>
Well seems the fact that https://wiki.openstreetmap.org/wiki/Tag:cuisine%3Dteahouse exists didn't seem to turn up. I would note that the wiki pages both for cuisine=tea and cuisine=teahouse were created by the same editor. |
@simonpoole Could you elaborate on what you mean? Note to self: |
There wasn't any reasoning why to prefer one value over the other or even a mention that the other value existed and was in use. |
@novolife what is your take on this?
Is |
I mistakenly added up the numbers for all/node/way.
When I posted the issue #1522 , I didn't find As for why I couldn't find it, it can only be attributed to the fact that this tag is not so commonly used and, like |
@novolife thanks for checking again. I accidentally misread the data and confused what we are using here. I think this is all good as is. I added the "possible synonyms" to the wiki. |
Description, Motivation & Context
Teahouse is common in UK, East Asia and Southeast Asia.
Related issues
Closes #1522
Links and data
Relevant OSM Wiki links:
Tea
Relevant tag usage stats:
1,810
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.