-
Notifications
You must be signed in to change notification settings - Fork 199
preset for shop=groundskeeping #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. Usage is still low, but the growth seems steady/organic.
I just added "… Store" to the name, to fit the rest of the shop
presets. @1ec5 do you think the name Lawn & Garden Equipment Store is ok?
There's an issue with the icon, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, the term "groundskeeping" should be added as well.
I suggest to also follow the check list that is provided by the PR template. Especially to check the wiki data item. |
Test-DocumentationPreview links & Sidebar Screenshotshttps://pr-1448--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=20.00/-37.83366/144.97788&background=USGS-The-National-Map-Topo&id=w971345869 SearchInfo-
|
Description, Motivation & Context
Shops selling only garden machinery, such as mowers, string trimmers, or chainsaws, are often tagged as shop=garden_centre, shop=hardware, or shop=doityourself, which is misleading. All these shops can sell garden machinery, but sometimes they don't.
Related issues
Closes #1428
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgroundskeeping
Relevant tag usage stats:
Usage of the tag: 564
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.