Skip to content

preset for shop=groundskeeping #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Conversation

Avan2021
Copy link
Contributor

Description, Motivation & Context

Shops selling only garden machinery, such as mowers, string trimmers, or chainsaws, are often tagged as shop=garden_centre, shop=hardware, or shop=doityourself, which is misleading. All these shops can sell garden machinery, but sometimes they don't.

Related issues

Closes #1428

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dgroundskeeping

Relevant tag usage stats:
Usage of the tag: 564

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general. Usage is still low, but the growth seems steady/organic.

I just added "… Store" to the name, to fit the rest of the shop presets. @1ec5 do you think the name Lawn & Garden Equipment Store is ok?

There's an issue with the icon, see below.

Copy link

@Oivo35 Oivo35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, the term "groundskeeping" should be added as well.

@tordans
Copy link
Collaborator

tordans commented Feb 18, 2025

I suggest to also follow the check list that is provided by the PR template. Especially to check the wiki data item.

@Avan2021
Copy link
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1448--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=20.00/-37.83366/144.97788&background=USGS-The-National-Map-Topo&id=w971345869
Screenshot 2025-02-19 103730

Search

Screenshot 2025-02-19 102418

Info-i

Screenshot 2025-02-19 105125

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@Avan2021 Avan2021 requested a review from Oivo35 February 19, 2025 11:00
@tyrasd tyrasd merged commit 11ee477 into openstreetmap:main Feb 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preset for shop=groundskeeping
4 participants