Skip to content

add shop-bbq preset #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

add shop-bbq preset #1430

merged 3 commits into from
Feb 27, 2025

Conversation

andrewharvey
Copy link
Contributor

@andrewharvey andrewharvey commented Jan 30, 2025

Description, Motivation & Context

Add a preset for shop=bbq a shop selling bbq's and bbq equipment.

Relevant tag usage stats:

currently limited use

2025-01-30_20-25

Test-Documentation

Preview links & Sidebar Screenshots

https://pr-1430--ideditor-presets-preview.netlify.app/id/dist/#background=NSW_LPI_Imagery&disable_features=boundaries&id=n12543268487&locale=en&map=20.96/-33.79695/151.18588

image

Search

image

image

image

image

Info-i

image

Wording

  • American English

unsure, would you call this a "Grill Store"?

We already have "Barbecue Restaurant" and "Barbecue/Grill" so based on that I've used "Barbecue Store" but happy to take input for Americans.

  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Apparently "Barbecue" is mostly used globally and "Barbeque" in AU/NZ so I've gone with "Barbecue" for the US name and listed both as terms. Then translators can take it from there.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Member

tyrasd commented Feb 24, 2025

currently limited use

75 is actually really low, well below the "threshold" of the other shop presets (IIRC, the shop presets with the fewest occurrences are around the 500 mark). 🤔

@tordans
Copy link
Collaborator

tordans commented Feb 25, 2025

One thing that would speak to adding it is that it is use in NSI https://github.com/osmlab/name-suggestion-index/pull/10416/files
I kind of think we should try to add all the presents that NSI references (which is #362) … but then again that is not really a reason since users will never see the preset given that NSI will overwrite most occurrences(?)


We could put this on hold and look at the numbers again in a year…

@tyrasd
Copy link
Member

tyrasd commented Feb 26, 2025

Good point with keeping in sync with NSI.

Also, I took a second look at the OSM data, and it seems like many BBQ/Grill stores seem to be currently wrongly tagged, for example as shop=outdoor or shop=kitchen, shop=yes, etc. – yet another argument to make an exception for the inclusion of this preset

@tyrasd tyrasd merged commit 2763fbd into openstreetmap:main Feb 27, 2025
5 checks passed
@andrewharvey andrewharvey deleted the shop-bbq branch February 27, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants