Use American English spelling for Amphitheater preset #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍱 You can preview the tagging presets of this pull request here. |
|
Could you / someone also have a look at the translation system if the GB translation is in place? |
|
Yes, the British English translation is in place, though it’ll need to be reconfirmed anyways after Transifex syncs with this change. The string has not yet been translated into other regional English locales. |
tordans
approved these changes
Oct 24, 2024
|
Sounds good, merged and over to you for the Transifex update :). |
|
I updated all the English localizations except English (Philippines). Not sure of the correct form there, so I’ll leave it to that localization team’s translators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation & Context
Currently, the
theatre:type=amphipreset is using the British spelling for its label (amphitheatre), however according to the contributing documentation, the JSON files in this repository should be in American English. This PR changes the label of this preset to "Amphitheater"tldr 🇺🇸 🇺🇸 🇺🇸 🦅💥 🦅💥
Links and data
https://en.wikipedia.org/wiki/Amphitheatre