-
Notifications
You must be signed in to change notification settings - Fork 199
Add deprecation rules for cycleway=opposite
#Part1
#1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🍱 You can preview the tagging presets of this pull request here. |
We found cases where oneway=yes is not the right update path because access tags are used instead. We assume, that oneway=yes is usually tagged already, so we don't need to add it to the replacement. However, the oneway:bicycle=no is used less often and also does less harm in case someone does apply the deprecation in cases where it should not be applied.
Thanks for the review. I will merge this now. |
"replace": {"oneway:bicycle": "no", "cycleway:both": "no"} | ||
}, | ||
{ | ||
"old": {"cycleway:left": "opposite"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe for consistency there could also be a rule for cycleway:right=opposite
; I'm thinking of countries with left hand default traffic where this tag would have made sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me the ~500 times that is used does not merit adding it here. I think those need to be cleaned up with a MapRoulette Challenge or something similar.
But if you prefer, we can add it, of course. Ideally we should try to update the guidelines with something along the lines "low usage is OK when is "a system" of deprecations being added" (wording TODO).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, true. It also seems like much of the data is not even in left hand traffic countries. So, a deprecation rule might be even less useful for those. Let's keep it as is. 👍
This solves the main issues described in #1271 to put the recently approved deprecation of the
cycleway=opposite
tagging into our deprecation rules.This is the one with the most usage (46k + 4k) ATM (Usage stats)
I suggest we merge this separate of other possible deprecations. I will create a separate issue for those.