-
Notifications
You must be signed in to change notification settings - Fork 199
Add crossing=informal
as unsearchable preset for point and line geometries
#1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crossing=informal
as unsearchable preset for point and line geometries
#1140
Conversation
🍱 You can preview the tagging presets of this pull request here. |
This would address / fix #1056 |
The `terms` are not used by iD but maybe other editors use them.
It looks like SC actually does not tag this as `highway=crossing`
I ran into this again the other day and think we should merge this as an unsearchable preset for now. Out in the wil: I think we should support this since SC supports it. However, it should be unsearchable IMO, because…
I changes a few things in this PR:
One thing I did not add is a translated value for the Given the state of the tagging described above I think we should keep it this way. It would be very hard to find a 2-3 word name for those crossings that will be easy to understand for users. SC has more context that it can use to guide users and still there are miss matches. I fear that promoting the tag further is too early. Testing: Data item looks good: Icon looks good: |
crossing=informal
as unsearchable preset for point and line geometries
@tyrasd I merged this now but you might want to double check this. My reasoning is in #1140 (comment) |
I'm currently adding a lot of informal paths, and just stumbled upon one that crosses a large road. I thought I'd add a crossing for the point but there was no preset for informal crossings. I almost made it an unmarked crossing but after browsing the wiki it seems informal crossing is correct. However, there's currently no preset for informal crossings which makes it hard to add, even harder as they shouldn't have the highway tag.
Informal crossings are well documented on the Wiki: https://wiki.openstreetmap.org/wiki/Tag:crossing%3Dinformal