Skip to content

Add crossing=informal as unsearchable preset for point and line geometries #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2025

Conversation

mikaeldui
Copy link
Contributor

@mikaeldui mikaeldui commented Feb 26, 2024

I'm currently adding a lot of informal paths, and just stumbled upon one that crosses a large road. I thought I'd add a crossing for the point but there was no preset for informal crossings. I almost made it an unmarked crossing but after browsing the wiki it seems informal crossing is correct. However, there's currently no preset for informal crossings which makes it hard to add, even harder as they shouldn't have the highway tag.

Informal crossings are well documented on the Wiki: https://wiki.openstreetmap.org/wiki/Tag:crossing%3Dinformal

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Member

tyrasd commented Feb 27, 2024

This would address / fix #1056

tordans added 4 commits April 20, 2025 18:09
The `terms` are not used by iD but maybe other editors use them.
It looks like SC actually does not tag this as `highway=crossing`
@tordans
Copy link
Collaborator

tordans commented Apr 20, 2025

I ran into this again the other day and think we should merge this as an unsearchable preset for now.

Out in the wil:
Since SC uses the tag, there are crossings that just don't show up right ATM, eg (from GoMap):

image image

I think we should support this since SC supports it.

However, it should be unsearchable IMO, because…

I changes a few things in this PR:

  1. I made the preset unsearchable
  2. I added a corresponding line based preset to give users a way to use the same logic when mapping sidewalks as separate geometries. Those are only use 2k times for now, but keeping line and point data in sync is important IMO.
    In my example below the used did not add any sub tag "crossing type" at all, which is not better IMO https://www.openstreetmap.org/way/1079416103. Also, once we have Adopt Rapid's sidewalk and curb mapping improvements to iD iD#10757 in place point and line data should have a match.
    image

One thing I did not add is a translated value for the crossing=* field which means this value still shows up as a raw value

image

Given the state of the tagging described above I think we should keep it this way. It would be very hard to find a 2-3 word name for those crossings that will be easy to understand for users. SC has more context that it can use to guide users and still there are miss matches. I fear that promoting the tag further is too early.


Testing:

https://pr-1140--ideditor-presets-preview.netlify.app/id/dist/#locale=en&disable_features=boundaries&map=20.30/52.46062/13.53049&background=Bing&id=n9894826209

Data item looks good:

image

Icon looks good:
It uses the same as unmarked which is fitting.

image

Closes #1056
Checks one box in #1410

@tordans tordans changed the title Add informal crossing Add crossing=informal as unsearchable preset for point and line geometries Apr 20, 2025
@tordans tordans merged commit 26abac8 into openstreetmap:main Apr 20, 2025
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Apr 20, 2025

@tyrasd I merged this now but you might want to double check this. My reasoning is in #1140 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants