Renewal form error handling #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
renewal-form-error-handling
branch
2 times, most recently
from
423a742 to
bd81565
Compare
multiselect.js -> multiselect.tsx
Include loading messages for those sections Style button to indicate disabled
RoyEJohnson
force-pushed
the
renewal-form-error-handling
branch
from
bd81565 to
5d1451d
Compare
jivey
approved these changes
Feb 19, 2025
| @@ -1,8 +1,8 @@ | |||
| import {useReducer, useCallback} from 'react'; | |||
| import buildContext from '~/components/jsx-helpers/build-context'; | |||
|
|
|||
| function useContextValue({maxSelections}) { | |||
| const [data, dispatch] = useReducer((state, [action, item]) => { | |||
| function useContextValue<T extends {value: string; text: string}>({maxSelections}: {maxSelections: number}) { | |||
There was a problem hiding this comment.
Would adding label let you remove the as Item[] here?
There was a problem hiding this comment.
I tried it, but it's used in sf-book-context and the books structure there doesn't include a label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-759
It will be useful to look at the individual commits for the main files ported from js->tsx. All of them are ported in "Port relevant modues to TS, fix lint issues". Most of them are updated there, but I had to give multiselect its own separate commit for its updates.
renewal-form.tsx is updated in several commits (the functional change for this PR is in "Disable submit until user and adoption info have loaded", and I removed some unused branches in "Test coverage").