Fix html validation errors #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
fix-html-validation-errors
branch
5 times, most recently
from
0f09f4b to
2f20f3c
Compare
bethshook
reviewed
Apr 16, 2024
| <MainMenuItems /> | ||
| <UpperMenu /> | ||
| </ul> | ||
| <React.Fragment> |
There was a problem hiding this comment.
not sure this is needed here?
There was a problem hiding this comment.
There are two DropdownContextProvider units, so I had to wrap them in a Fragment (because of the every-component-must-return-a-single-root-element rule)
bethshook
approved these changes
Apr 16, 2024
Does nothing, since React rewrites index.html with the trailing slashes.
Unclutter dropdown-context
RoyEJohnson
force-pushed
the
fix-html-validation-errors
branch
from
2f20f3c to
2daad50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCO-194
The primary goal was to differentiate the desktop and mobile dropdown menu IDs. I did that by adding
prefixto the dropdown context. While I was there, I converted dropdown-context to TS.