Skip to content

Structure lists of links in footer as lists #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

Structure lists of links in footer as lists #2560

merged 1 commit into from
Mar 29, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Mar 26, 2024 •
edited by jira bot
Loading

@RoyEJohnson RoyEJohnson requested a review from Dantemss March 26, 2024 15:19
@RoyEJohnson
Copy link
Contributor Author

This is basically the same change as in Rex. That's why I picked you to review, @Dantemss

Dantemss
Dantemss approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Dantemss Dantemss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me that the children can be used as a key in the <li> but if it doesn't complain, maybe it's fine?

@RoyEJohnson
Copy link
Contributor Author

Preact lets you use anything as a key as long as it is stable between renders.

@RoyEJohnson RoyEJohnson force-pushed the fix-footer-structure branch from d5abc09 to 3f00880 Compare March 29, 2024 20:15
@RoyEJohnson RoyEJohnson merged commit dee3a2b into main Mar 29, 2024
1 check passed
@RoyEJohnson RoyEJohnson deleted the fix-footer-structure branch March 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dantemss Dantemss Dantemss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyEJohnson @Dantemss