Skip to content

Add new Lead fields for new Accounts instructor flow #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 6, 2020
Merged

Add new Lead fields for new Accounts instructor flow #27

merged 7 commits into from
Jul 6, 2020

Conversation

BryanHouston
Copy link
Contributor

No description provided.

@BryanHouston BryanHouston requested a review from Dantemss July 2, 2020 21:58
@BryanHouston BryanHouston marked this pull request as ready for review July 2, 2020 22:01
@BryanHouston BryanHouston changed the title Add who_chooses_books to Lead Add new Lead fields for new Accounts instructor flow Jul 6, 2020
@BryanHouston BryanHouston changed the title Add new Lead fields for new Accounts instructor flow Add Lead fields for new Accounts instructor flow Jul 6, 2020
@BryanHouston BryanHouston force-pushed the add_who_chooses_books_to_lead branch 3 times, most recently from 0654076 to 6d82d40 Compare July 6, 2020 16:26
@BryanHouston BryanHouston force-pushed the add_who_chooses_books_to_lead branch 7 times, most recently from 4eb4c74 to c03d4d4 Compare July 6, 2020 19:21
@BryanHouston BryanHouston changed the title Add Lead fields for new Accounts instructor flow Add new Lead fields for new Accounts instructor flow Jul 6, 2020
@BryanHouston BryanHouston force-pushed the add_who_chooses_books_to_lead branch 2 times, most recently from e3aed36 to 1c9323c Compare July 6, 2020 20:15
@BryanHouston BryanHouston force-pushed the add_who_chooses_books_to_lead branch from 1c9323c to 1711805 Compare July 6, 2020 21:19
Dantemss
Dantemss approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify how the verification_status field in Lead interacts with the faculty_verified field in Contact.

@BryanHouston BryanHouston merged commit b089a8c into master Jul 6, 2020
@BryanHouston BryanHouston deleted the add_who_chooses_books_to_lead branch July 6, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dantemss Dantemss Dantemss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanHouston @Dantemss