1820full WIP #1540
Draft
1820full WIP #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fitst attempt for a GUI to set names
move code for setting of name/channel
reduce size by disabling TLS temporarily disable multiline startup again
LynxChaus
reviewed
Mar 20, 2025
|
|
||
| // poststr_h2(request, "Here you can configure DS18B20 sensors detected or configured"); | ||
| hprintf255(request, "<h2>Here you can configure DS18B20 sensors detected or cinfigured</h2><h5>Configure DS18B20 devices detected</h5><form action='/cfg_ds18b20'>"); |
| DS1820_LOG(DEBUG, "DS18B20_OnEverySecond ..."); | ||
| if(Pin != 99) // so there is at least one Pin defined | ||
| { |
There was a problem hiding this comment.
Invert logic here for better reading and less indentations:
if (Pin == 99) {
bk_printf("No Pin found\r\n");
DS1820_LOG(INFO, "No Pin found\r\n");
return;
}
|
Not working on BK7231T - no ds18b20 detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.