Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINC-1380: [release 4.15] Add shell and unicode sast pipeline tasks #2792

Open
wants to merge 3 commits into
base: release-4.15
Choose a base branch
from

Conversation

wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Apr 1, 2025

https://issues.redhat.com/browse/KONFLUX-2264

ran

curl -sL https://github.com/simonbaird/konflux-pipeline-patcher/raw/main/pipeline-patcher |
  bash -s add-tasks . sast-shell-check,sast-unicode-check &&
  git commit .tekton/*.yaml -m "Add shell and unicode sast pipeline tasks" \
    -m "https://issues.redhat.com/browse/KONFLUX-2264"

@wgahnagl wgahnagl changed the title [release 4.15] Sast unicode check 4.15 [release 4.15] Add shell and unicode sast pipeline tasks Apr 1, 2025
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@wgahnagl wgahnagl changed the title [release 4.15] Add shell and unicode sast pipeline tasks WINC-1380: [release 4.15] Add shell and unicode sast pipeline tasks Apr 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@wgahnagl: This pull request references WINC-1380 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/KONFLUX-2264

ran

curl -sL https://github.com/simonbaird/konflux-pipeline-patcher/raw/main/pipeline-patcher |
 bash -s add-tasks . sast-shell-check,sast-unicode-check &&
 git commit .tekton/*.yaml -m "Add shell and unicode sast pipeline tasks" \
   -m "https://issues.redhat.com/browse/KONFLUX-2264"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wgahnagl
Copy link
Contributor Author

wgahnagl commented Apr 3, 2025

/retest

Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes, wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

@wgahnagl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants