Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Azure machineSet to conditionally set ManagedIdentity #2781

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Allow Azure machineSet to conditionally set ManagedIdentity #2781

merged 2 commits into from
Mar 26, 2025

Conversation

jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Mar 25, 2025 •
edited
Loading

jrvaldes added 2 commits March 25, 2025 15:15
@jrvaldes
[e2e] remove ManagedIdentity from Azure machineSet
210d3fe 
managed identity are now inferred and support other resource groups

openshift/machine-api-provider-azure#133
@jrvaldes
[hack] Adjust machineset.sh for Azure
b1d499e 
This commit reacts to the ManagedIdentity changes in Azure machineSets.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jrvaldes
Copy link
Contributor Author

/test azure-e2e-operator

@jrvaldes
Copy link
Contributor Author

fixes

@jrvaldes
Copy link
Contributor Author

/test azure-e2e-upgrade

@jrvaldes jrvaldes mentioned this pull request Mar 25, 2025
Open
@jrvaldes jrvaldes marked this pull request as ready for review March 26, 2025 02:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2025
@jrvaldes
Copy link
Contributor Author

azure-e2e-operator passed

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_windows-machine-config-operator/2781/pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator/1904614191134674944

@jrvaldes
Copy link
Contributor Author

azure-e2e-upgrade passed

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_windows-machine-config-operator/2781/pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-upgrade/1904614973468839936

@sebsoto
Copy link
Contributor

sebsoto commented Mar 26, 2025

/approve

@sebsoto
Copy link
Contributor

sebsoto commented Mar 26, 2025

/lgtm

@sebsoto
Copy link
Contributor

sebsoto commented Mar 26, 2025

/override ci/prow/nutanix-e2e-operator ci/prow/vsphere-disconnected-e2e-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/nutanix-e2e-operator, ci/prow/vsphere-disconnected-e2e-operator

In response to this:

/override ci/prow/nutanix-e2e-operator ci/prow/vsphere-disconnected-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jrvaldes
Copy link
Contributor Author

/retest

@jrvaldes
Copy link
Contributor Author

No backports are needed.

@openshift-merge-bot openshift-merge-bot bot merged commit 7efe626 into openshift:master Mar 26, 2025
19 checks passed
@mburke5678
Copy link

@jrvaldes @sebsoto We should remove the managedIdentity parameter from the Azure machine set example in the docs?

@jrvaldes
Copy link
Contributor Author

@jrvaldes @sebsoto We should remove the managedIdentity parameter from the Azure machine set example in the docs?

Good call, possibly yes. Will defer to @sebsoto .

@mburke5678
Copy link

We should remove the managedIdentity parameter from the Azure machine set example in the docs?

Will defer to @sebsoto .

@sebsoto Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@sebsoto sebsoto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrvaldes @sebsoto @mburke5678