Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release 4.18] submodule update 03 17 #2777

Closed
wants to merge 2 commits into from
Closed

[release 4.18] submodule update 03 17 #2777

wants to merge 2 commits into from

Conversation

wgahnagl
Copy link
Contributor

This commit was generated using hack/update_submodules.sh

@wgahnagl
[vendor] Use v1.31.6+6020cf5 k8s and OpenShift libraries
c934cf7 
This commit was generated using hack/update_submodules.sh
@wgahnagl wgahnagl changed the title [release 4.18] submodule update 03 18 [release 4.18] submodule update 03 17 Mar 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
Once this PR has been reviewed and has the lgtm label, please assign mansikulkarni96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wgahnagl
[vendor] fix golang.org/x/exp for go1.22
cd35bbe 
ran:
go mod tidy && go mod vendor && go mod verify
@jrvaldes
Copy link
Contributor

/retest-required

jrvaldes
jrvaldes suggested changes Mar 26, 2025
View reviewed changes
go.mod Outdated
Comment on lines 3 to 4
go 1.22.9
go 1.23.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.18 must be kept with go1.22, please revert

@jrvaldes
Copy link
Contributor

jrvaldes commented Mar 26, 2025 •
edited
Loading

/hold

to revert 1.23.0 changes

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/nutanix-e2e-operator cd35bbe link true /test nutanix-e2e-operator
ci/prow/azure-e2e-operator cd35bbe link true /test azure-e2e-operator
ci/prow/aws-e2e-operator cd35bbe link true /test aws-e2e-operator
ci/prow/azure-e2e-upgrade cd35bbe link true /test azure-e2e-upgrade
ci/prow/vsphere-disconnected-e2e-operator cd35bbe link true /test vsphere-disconnected-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wgahnagl wgahnagl closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrvaldes jrvaldes jrvaldes requested changes

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgahnagl @jrvaldes