ci-operator/step-registry/openshift/e2e/test: Add TEST_COMMAND and TEST_SUITE #9676
Conversation
…ST_SUITE Taking advantage of openhsift/ci-tools@62e7498d66 (ci-operator multi-stage: add step parameters, 2020-05-27, openshift/ci-tools#854). This commit doesn't override the defaults yet, but a useful override would be: TEST_COMMAND=run-upgrade TEST_SUITE=all This replaces test-suite.txt, which landed in a2fd8c3 (step-registry: add Origin E2E test step, 2020-01-31, openshift#6965), and also had no consumers.
openshift-ci-robot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Heh, you beat me to it by half a day: bbguimaraes@92e589e. Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -2,6 +2,13 @@ ref: | |||
| as: openshift-e2e-test | |||
| from: tests | |||
| commands: openshift-e2e-test-commands.sh | |||
| env: | |||
| - name: TEST_COMMAND | |||
There was a problem hiding this comment.
This unfortunately doesn’t solve the common “run a type of suite like upgrade and then run the normal suite”.
I would recommend not abstracting the test command into multiple steps, just accept a test command like we do in CI chunks today. I don’t think this is going to address our needs well.
There was a problem hiding this comment.
No worries, we can still iterate ;)
Taking advantage of openhsift/ci-tools@62e7498d66 (openshift/ci-tools#854). This commit doesn't override the defaults yet, but a useful override would be:
This replaces
test-suite.txt, which landed in a2fd8c3 (#6965), and also had no consumers.