Add support to the step registry for the openshift-sdn modes #8157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
requested review from
alexanderConstantinescu and
JacobTanenbaum
dcbw
reviewed
Apr 7, 2020
...tor/config/openshift/cluster-network-operator/openshift-cluster-network-operator-master.yaml
Outdated
Show resolved
Hide resolved
openshift-ci-robot
added
the
needs-rebase
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
removed
the
needs-rebase
pecameron
force-pushed
the
sdn858
branch
6 times, most recently
from
b2d2fbe to
5cb2bfd
Compare
dcbw
reviewed
Apr 8, 2020
...tor/config/openshift/cluster-network-operator/openshift-cluster-network-operator-master.yaml
Outdated
Show resolved
Hide resolved
dcbw
reviewed
Apr 8, 2020
...tor/config/openshift/cluster-network-operator/openshift-cluster-network-operator-master.yaml
Outdated
Show resolved
Hide resolved
dcbw
reviewed
Apr 8, 2020
| @@ -0,0 +1,11 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
@pecameron let's put network people in here
dcbw
reviewed
Apr 8, 2020
ci-operator/step-registry/ipi/conf/sdn/ipi-conf-sdn-commands.sh
Outdated
Show resolved
Hide resolved
dcbw
reviewed
Apr 8, 2020
ci-operator/step-registry/origin/e2e-gcp-sdn/origin-e2e-gcp-sdn-workflow.yaml
Outdated
Show resolved
Hide resolved
|
@pecameron take a look at PR #8075 which is what I think you should follow here. Basically, add a workflow like https://github.com/openshift/release/pull/8075/files#diff-7e9e1262c023bd4b0886f0a5e0ad5231 that does the ipi-conf-aws, then drops a manifest file that sets the right OpenShiftSDN network mode, then continues the install and runs the e2e tests. |
pecameron
force-pushed
the
sdn858
branch
3 times, most recently
from
45e8bae to
e4ef3dd
Compare
|
/retest |
pecameron
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@dcbw passing tests. Anything else before merge? |
|
@stevekuznetsov @wking Is there more to do for this PR? PTAL |
ci-operator/step-registry/origin/e2e-aws-sdn-multi/origin-e2e-aws-sdn-multi-workflow.yaml
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/origin/e2e-aws-sdn-single/origin-e2e-aws-sdn-single-workflow.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,10 @@ | |||
| ref: | |||
| as: sdn-conf-multi-manifest | |||
There was a problem hiding this comment.
I don't know if this is a big deal but it might be cleaer to change this to sdn-conf-multitenant-manifest? it might be clearer if we ever need to create many manifests in the future
There was a problem hiding this comment.
I was keeping the length of the filename down.
ci-operator/step-registry/sdn/conf/single-manifest/sdn-conf-single-manifest-ref.yaml
Show resolved
Hide resolved
|
/assign stevekuznetsov |
|
/assign @stevekuznetsov |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
Rebased |
|
@pecameron: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/SDN-858 Signed-off-by: Phil Cameron <[email protected]>
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
@dcbw @stevekuznetsov @wking This didin't get merged 4/17. A merge ahead of it forced a rebase. Can this be merged now? |
|
@stevekuznetsov @dcbw Is there anything holding up getting this merged? |
stevekuznetsov
approved these changes
Apr 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, pecameron, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@pecameron: Updated the following 7 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/SDN-858
Signed-off-by: Phil Cameron [email protected]