-
Notifications
You must be signed in to change notification settings - Fork 1.9k
ipi-install-install: don't share the installer log #7924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipi-install-install: don't share the installer log #7924
Conversation
@@ -46,8 +46,7 @@ cp \ | |||
-t "${SHARED_DIR}" \ | |||
"${dir}/auth/kubeconfig" \ | |||
"${dir}/metadata.json" \ | |||
"${dir}/terraform.tfstate" \ | |||
"${dir}/.openshift_install.log" | |||
"${dir}/terraform.tfstate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear to me why we need this one either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was definitely necessary when it was added.
Signed-off-by: Steve Kuznetsov <[email protected]>
9e176a3
to
0c19ccd
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@stevekuznetsov: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Steve Kuznetsov [email protected]
/assign @wking