Skip to content

ci-operator/step-registry/ipi/ipi-workflow: Drop install-only workflow #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Feb 24, 2020

Job authors who need their own end-to-end test logic will need to define their own workflow, like a2fd8c3 (#6965) did for origin-e2e. There's no way to piggy-back on a generic workflow to inject a custom test; but you can lean on existing pre and post chains.

Job authors who need their own end-to-end test logic will need to
define their own workflow, like a2fd8c3 (step-registry: add Origin
E2E test step, 2020-01-31, openshift#6965) did for origin-e2e.  There's no way
to piggy-back on a generic workflow to inject a custom test; but you
can lean on existing pre and post chains.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@wking
Copy link
Member Author

wking commented Feb 24, 2020

@AlexNPavel pointed out that you can use the ipi workflow and override the test with your custom test step/chain:

- as: org-repo-e2e
  steps:
    cluster_profile: aws
    workflow: ipi
    test:
    - ref: org-repo-e2e

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

In response to this:

@AlexNPavel pointed out that you can use the ipi workflow and override the test with your custom test step/chain:

- as: org-repo-e2e
 steps:
   cluster_profile: aws
   workflow: ipi
   test:
   - ref: org-repo-e2e

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-ipi-workflow branch February 24, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants