ci-operator/templates/openshift: Remove Terraform-state-based SSH gathers #6854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hers Like 970ec02 (ci-operator/step-registry/ipi/deprovision/artifacts/bootstrap: Drop gather, 2019-12-10, openshift#6336), except for the templates instead of the step registry.
wking
force-pushed
the
drop-more-manual-ssh-gathers
branch
from
601ec88 to
7baa9f2
Compare
openshift-ci-robot
added
the
size/L
|
/test prow-config-filenames |
|
This should help with rhbz#1793287. |
|
@wking can you look into these rehearsal failures and make sure they aren't caused by these changes? otherwise lgtm. /approve |
openshift-ci-robot
added
the
approved
I did; they aren't. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 27 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/origin
that referenced
this pull request
Feb 17, 2020
This reverts commit ca35cd6, openshift#22592. As described in that commit message, the access was broadened to allow ssh from containers launched from the tests image. But since openshift/release@7baa9f2e44 (ci-operator/templates/openshift: Remove Terraform-state-based SSH gathers, 2020-01-25, openshift/release#6854) landed, we no longer need to SSH from those containers. Restore the usual access restrictions to address CVE-2019-19347[1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1793287
tbuskey
pushed a commit
to tbuskey/origin
that referenced
this pull request
Mar 19, 2020
This reverts commit ca35cd6, openshift#22592. As described in that commit message, the access was broadened to allow ssh from containers launched from the tests image. But since openshift/release@7baa9f2e44 (ci-operator/templates/openshift: Remove Terraform-state-based SSH gathers, 2020-01-25, openshift/release#6854) landed, we no longer need to SSH from those containers. Restore the usual access restrictions to address CVE-2019-19347[1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1793287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like 970ec02 (#6336), except for the templates instead of the step registry. CC @crawford