Skip to content

CNTRLPLANE-1042: Run all tests in hcp aks #66655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNTRLPLANE-1042: Run all tests in hcp aks #66655

wants to merge 1 commit into from
+1 −1

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 2, 2025

No description provided.

@enxebre
Copy link
Member Author

enxebre commented Jul 2, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@enxebre enxebre changed the title Run all tests in hcp aks CNTRLPLANE-1042: Run all tests in hcp aks Jul 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 2, 2025 •
edited by openshift-ci bot
Loading

@enxebre: This pull request references CNTRLPLANE-1042 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci openshift-ci bot requested review from bryan-cox and csrwng July 2, 2025 13:02
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@enxebre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.21-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-aks openshift/hypershift presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-master-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.21-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-hypershift-e2e-aks openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.21-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.20-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.19-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-master-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.21-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.20-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.19-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-master-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.21-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.20-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-azure-release-4.19-hypershift-e2e-aks openshift/cluster-api-provider-azure presubmit Registry content changed
pull-ci-openshift-csi-operator-main-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.21-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.20-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.19-hypershift-e2e-aks openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-main-hypershift-e2e-aks openshift/cluster-storage-operator presubmit Registry content changed

A total of 34 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@enxebre
Copy link
Member Author

enxebre commented Jul 2, 2025

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

We should not regress in 4.19 either since that is the GA OCP version.

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@enxebre
Copy link
Member Author

enxebre commented Jul 3, 2025

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

enxebre added a commit to enxebre/hypershift that referenced this pull request Jul 3, 2025
@enxebre
Disable createClusterNone for azure and scope down verifyResourceGrou…
8b01d30 
…pLocationsMatch check

openshift/release#66655 enables all tests to run on aks-e2e
This is failing because of the createClusterNone test.
Scoping down verifyResourceGroupLocationsMatch to only run on azure platform is fix that should solve the current failure.
Besides this test provides no value and we want to focus on increasing valuable coverage so this PR just disbled it for azure
@enxebre enxebre mentioned this pull request Jul 3, 2025
Merged
4 tasks
@enxebre
Copy link
Member Author

enxebre commented Jul 7, 2025

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@enxebre
Copy link
Member Author

enxebre commented Jul 7, 2025

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@enxebre
Copy link
Member Author

enxebre commented Jul 7, 2025

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks
/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@enxebre: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@bryan-cox
Copy link
Member

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/hypershift that referenced this pull request Jul 8, 2025
@enxebre
Disable createClusterNone for azure and scope down verifyResourceGrou…
f39db42 
…pLocationsMatch check

openshift/release#66655 enables all tests to run on aks-e2e
This is failing because of the createClusterNone test.
Scoping down verifyResourceGroupLocationsMatch to only run on azure platform is fix that should solve the current failure.
Besides this test provides no value and we want to focus on increasing valuable coverage so this PR just disbled it for azure
sdminonne pushed a commit to sdminonne/hypershift that referenced this pull request Jul 8, 2025
@enxebre @sdminonne
Disable createClusterNone for azure and scope down verifyResourceGrou…
a4a8ef4 
…pLocationsMatch check

openshift/release#66655 enables all tests to run on aks-e2e
This is failing because of the createClusterNone test.
Scoping down verifyResourceGroupLocationsMatch to only run on azure platform is fix that should solve the current failure.
Besides this test provides no value and we want to focus on increasing valuable coverage so this PR just disbled it for azure
@enxebre
Copy link
Member Author

enxebre commented Jul 9, 2025

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jparrill
Copy link
Contributor

jparrill commented Jul 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enxebre
Copy link
Member Author

enxebre commented Jul 9, 2025

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@enxebre
Copy link
Member Author

enxebre commented Jul 9, 2025

/pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

@openshift-ci-robot
Copy link
Contributor

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/release-4.19/e2e-aks 9ab56ed link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.19-e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Jul 10, 2025

needs to unblock main coverage openshift/hypershift#6416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox Awaiting requested review from bryan-cox

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enxebre @openshift-ci-robot @bryan-cox @jparrill