Skip to content

STOR-2413: Periodics tests in Sippy #66610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

STOR-2413: Periodics tests in Sippy #66610

wants to merge 6 commits into from

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Jul 1, 2025 •
edited by openshift-ci bot
Loading

This PR addresses STOR-2413 by making Storage periodic tests visible in Sippy and cleaning up unused periodics to improve resource utilization and test visibility.

I have added Slack reporter config to our components for future proofing, so we can add periodic test reporters more easily.

Removed old running jobs that are no longer necessary.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2025 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2413 which is a valid jira issue.

In response to this:

This PR addresses STOR-2413 by making Storage periodic tests visible in Sippy and cleaning up unused periodics to improve resource utilization and test visibility.

I have added Slack reporter config to our components for future proofing, so we can add periodic test reporters more easily.

Removed old running jobs that are no longer necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and dobsonj July 1, 2025 14:16
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2025
dfajmon added 6 commits July 3, 2025 16:45
@dfajmon
update periodics for aws-ebs-csi-driver
5418a9b 
Update periodic tests to their respective files. Enable tests to be visible in Sippy.
@dfajmon
update periodics for csi-operator
0444351 
Update periodic tests to their respective files. Enable tests to be visible in Sippy.
@dfajmon
update periodics for gcp-filestore-csi-driver-operator
a791094 
Update periodic tests to their respective files. Enable tests to be visible in Sippy.
@dfajmon
update periodics for gcp-pd-csi-driver-operator
bf2bd83 
Update periodic tests to their respective files. Enables tests to be visible in Sippy.
@dfajmon
update periodics for gcp-pd-csi-driver
73426f6
@dfajmon
add slack reporter to storage components
a52aa83
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon
Once this PR has been reviewed and has the lgtm label, please assign engelmi, jsafrane, ydayagi, yussufsh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dfajmon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-release-4.17-periodics-ci-index-aws-efs-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.17-periodics-ci-index-smb-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.18-periodics-ci-index-aws-efs-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.18-periodics-ci-index-smb-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.19-periodics-ci-index-aws-efs-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.19-periodics-ci-index-smb-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.20-periodics-ci-index-aws-efs-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-csi-operator-release-4.20-periodics-ci-index-smb-csi-driver-operator-bundle openshift/csi-operator presubmit Presubmit changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.17-periodics-ci-index-gcp-filestore-csi-driver-operator-bundle openshift/gcp-filestore-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.18-periodics-ci-index-gcp-filestore-csi-driver-operator-bundle openshift/gcp-filestore-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.19-periodics-ci-index-gcp-filestore-csi-driver-operator-bundle openshift/gcp-filestore-csi-driver-operator presubmit Presubmit changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.20-periodics-ci-index-gcp-filestore-csi-driver-operator-bundle openshift/gcp-filestore-csi-driver-operator presubmit Presubmit changed
periodic-ci-openshift-gcp-pd-csi-driver-operator-release-4.19-periodics-periodic-e2e-gcp-csi-c3 N/A periodic Periodic changed
periodic-ci-openshift-gcp-pd-csi-driver-operator-release-4.18-periodics-periodic-e2e-gcp-csi-n4 N/A periodic Periodic changed
periodic-ci-openshift-aws-ebs-csi-driver-release-4.20-periodics-periodic-e2e-aws-csi-techpreview-volumeattributesclass N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.20-periodics-periodic-e2e-azure-file-csi N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.18-periodics-periodic-e2e-smb-csi N/A periodic Periodic changed
periodic-ci-openshift-gcp-pd-csi-driver-operator-release-4.20-periodics-periodic-e2e-gcp-csi-n4 N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.20-periodics-periodic-e2e-aws-efs-csi N/A periodic Periodic changed
periodic-ci-openshift-gcp-filestore-csi-driver-operator-release-4.20-periodics-periodic-e2e-gcp-filestore-csi N/A periodic Periodic changed
periodic-ci-openshift-gcp-pd-csi-driver-release-4.20-periodics-periodic-e2e-gcp-csi-techpreview-volumeattributesclass N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.19-periodics-periodic-e2e-aws-efs-csi N/A periodic Periodic changed
periodic-ci-openshift-gcp-filestore-csi-driver-operator-release-4.19-periodics-periodic-e2e-gcp-filestore-csi N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.19-periodics-periodic-e2e-azure-file-csi N/A periodic Periodic changed
periodic-ci-openshift-csi-operator-release-4.18-periodics-periodic-e2e-azure-file-csi N/A periodic Periodic changed

A total of 38 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jsafrane
jsafrane reviewed Jul 3, 2025
View reviewed changes
...csi-driver-operator/openshift-gcp-filestore-csi-driver-operator-release-4.19-presubmits.yaml
ci-operator.openshift.io/variant: periodics
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.19-periodics-ci-index-gcp-filestore-csi-driver-operator-bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a periodic job have pull- prefix + is in presubmits.yaml? There are many such jobs now, probably related to OLM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to all periodic jobs containing bundles. I will have to look more in-depth as to why it generates it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfajmon @openshift-ci-robot @jsafrane @openshift-merge-robot