-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MGMT-21001: Refactor assisted-events-stream CI config to stop pinning Go versions #66603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MGMT-21001: Refactor assisted-events-stream CI config to stop pinning Go versions #66603
Conversation
… Go versions • Switch build_root to from_repository: true, building the root image from the repo’s Dockerfile. • Drop the base_images stanza and the inputs block that referenced release:golang-1.21. • Regenerate and commit the updated presubmit job YAML via make update. This keeps the CI environment in sync with the Go version declared by the project and removes the need for future hard-coded bumps in openshift/release.
@yoavsc0302: This pull request references MGMT-21001 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yoavsc0302 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse max |
@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@yoavsc0302: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
• Switch build_root to from_repository: true, building the root image from the repo’s Dockerfile.
• Drop the base_images stanza and the inputs block that referenced release:golang-1.21.
• Regenerate and commit the updated presubmit job YAML via make update.
This keeps the CI environment in sync with the Go version declared by the project and removes the need for future hard-coded bumps in openshift/release.