Skip to content

MGMT-21001: Refactor assisted-events-stream CI config to stop pinning Go versions #66603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoavsc0302
Copy link

• Switch build_root to from_repository: true, building the root image from the repo’s Dockerfile.

• Drop the base_images stanza and the inputs block that referenced release:golang-1.21.

• Regenerate and commit the updated presubmit job YAML via make update.

This keeps the CI environment in sync with the Go version declared by the project and removes the need for future hard-coded bumps in openshift/release.

… Go versions

• Switch build_root to from_repository: true, building the root image from the repo’s Dockerfile.
• Drop the base_images stanza and the inputs block that referenced release:golang-1.21.
• Regenerate and commit the updated presubmit job YAML via make update.

This keeps the CI environment in sync with the Go version declared by the project and removes the need for future hard-coded bumps in openshift/release.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2025

@yoavsc0302: This pull request references MGMT-21001 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

• Switch build_root to from_repository: true, building the root image from the repo’s Dockerfile.

• Drop the base_images stanza and the inputs block that referenced release:golang-1.21.

• Regenerate and commit the updated presubmit job YAML via make update.

This keeps the CI environment in sync with the Go version declared by the project and removes the need for future hard-coded bumps in openshift/release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from CrystalChun and pastequo July 1, 2025 11:08
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoavsc0302
Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@yoavsc0302: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-assisted-events-stream-master-images openshift-assisted/assisted-events-stream presubmit Ci-operator config changed
pull-ci-openshift-assisted-assisted-events-stream-master-lint openshift-assisted/assisted-events-stream presubmit Ci-operator config changed
pull-ci-openshift-assisted-assisted-events-stream-master-template-generation openshift-assisted/assisted-events-stream presubmit Ci-operator config changed
pull-ci-openshift-assisted-assisted-events-stream-master-unit-test openshift-assisted/assisted-events-stream presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@danmanor
Copy link
Contributor

danmanor commented Jul 1, 2025

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@danmanor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

@yoavsc0302: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-assisted/assisted-events-stream/master/unit-test cdb90fd link unknown /pj-rehearse pull-ci-openshift-assisted-assisted-events-stream-master-unit-test
ci/rehearse/openshift-assisted/assisted-events-stream/master/template-generation cdb90fd link unknown /pj-rehearse pull-ci-openshift-assisted-assisted-events-stream-master-template-generation
ci/rehearse/openshift-assisted/assisted-events-stream/master/lint cdb90fd link unknown /pj-rehearse pull-ci-openshift-assisted-assisted-events-stream-master-lint
ci/rehearse/openshift-assisted/assisted-events-stream/master/images cdb90fd link unknown /pj-rehearse pull-ci-openshift-assisted-assisted-events-stream-master-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants