Skip to content

Remove kvm capability definition for coreos jobs #66172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcapiitao
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@jcapiitao jcapiitao force-pushed the remove_kvm_capability_definition branch from a42cfd2 to 6f3d429 Compare June 17, 2025 13:36
@jmguzik
Copy link
Contributor

jmguzik commented Jun 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
Copy link
Contributor

openshift-ci bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcapiitao, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcapiitao: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-coreos-rhel-coreos-config-main-rhcos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9next-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9next-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-scos-10-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-scos-10-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-scos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-scos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-rhcos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-rhcos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-rhcos-9next-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-rhcos-9next-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-scos-10-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-scos-10-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-scos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.20-scos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-rhcos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-rhcos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-rhcos-9next-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-rhcos-9next-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-scos-10-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-scos-10-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-scos-9-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-release-4.21-scos-9-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-validate coreos/rhel-coreos-config presubmit Ci-operator config changed

A total of 42 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jmguzik
Copy link
Contributor

jmguzik commented Jun 17, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jmguzik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 17, 2025
@jmguzik
Copy link
Contributor

jmguzik commented Jun 17, 2025

/hold

let me test one more thing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2025
Copy link
Contributor

openshift-ci bot commented Jun 17, 2025

@jcapiitao: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants