Skip to content

core-services/prow/02_config/_plugins: Require 4.3 bugs to depend on 4.4 bugs #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wking
Copy link
Member

@wking wking commented Dec 18, 2019

This should have happened when we stopped fast-forwarding 4.3 in 84b3e28 (#6080), because we need the dependencies to ensure we don't fix something in 4.3 but then not track and fix it in 4.4+.

…4.4 bugs

This should have happened when we stopped fast-forwarding 4.3 in
84b3e28 (Bump the branching job to current releases, 2019-11-25, openshift#6080),
because we need the dependencies to ensure we don't fix something in
4.3 but then not track and fix it in 4.4+.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2019
@wking wking force-pushed the require-4.3-to-depend-on-4.4 branch from 043f88a to 03f4ddc Compare December 18, 2019 11:53
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2019

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 043f88a9a70f35fe58bef10fb914b15d8a6ca10e link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit a460286 into openshift:master Jan 2, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the plugins configmap in namespace ci at cluster default using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml

In response to this:

This should have happened when we stopped fast-forwarding 4.3 in 84b3e28 (#6080), because we need the dependencies to ensure we don't fix something in 4.3 but then not track and fix it in 4.4+.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the require-4.3-to-depend-on-4.4 branch January 16, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants