-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPQE-28378: Retry when create vpc in ibmcloud fails #61548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xiuwang: This pull request references OCPQE-28378 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@xiuwang,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
43cd849
to
b5f9afe
Compare
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-ovn-hypershift-mce-ibmz-guest-critical-f14 |
@xiuwang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@xiuwang: This pull request references OCPQE-28378 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @phani2898 |
sleeptime=30 | ||
while [ $count -lt $max_retries ]; do | ||
count=$(( count + 1 )) | ||
echo "Try the $count time to create VPC..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to modify the echo statement to be little more meaningful like below
echo "Retry $count/5: Waiting for VPC to be successfully created ..."
echo "VPC $infra_name-vpc is created successfully" | ||
break | ||
else | ||
echo "Failed to create VPC on the $count time, the error code is $create_status" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to modify the echo statement to be little more meaningful like below
echo "Failed to create VPC after $count/5 retry, the error code is $create_status"
b5f9afe
to
a1c5e24
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phani2898, xiuwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiuwang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/pj-rehearse ack |
@xiuwang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
* Retry when create vpc in ibmcloud fails * Address echo comments --------- Co-authored-by: Xiuwang <[email protected]>
* Retry when create vpc in ibmcloud fails * Address echo comments --------- Co-authored-by: Xiuwang <[email protected]>
VPC creation failed a high ratio in hypershift-mce-ibmz-create-zvsicompute steps , add retry to improve the step success rate.