Skip to content

ci-operator/templates/openshift/installer/cluster-launch-installer-*: Drop *_REGION from teardown #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

ci-operator/templates/openshift/installer/cluster-launch-installer-*: Drop *_REGION from teardown #5079

merged 1 commit into from
Sep 18, 2019

Conversation

wking
Copy link
Member

@wking wking commented Sep 18, 2019

These came in with d00da5d (#3877), but the installer should be extracting the region from metadata.json.

/assign @abhinavdahiya

@wking
ci-operator/templates/openshift/installer/cluster-launch-installer-*:…
39d13eb 
… Drop *_REGION from teardown

These came in with d00da5d (templates/openshift/installer: Add
azure cluster test configuration, 2019-05-23, openshift#3877), but the
installer should be extracting the region from metadata.json [1,2].

[1]: https://github.com/openshift/installer/blob/d9a9648cf2330d467cca9f2988846d031464125e/pkg/types/aws/metadata.go#L5
[2]: https://github.com/openshift/installer/blob/d9a9648cf2330d467cca9f2988846d031464125e/pkg/types/azure/metadata.go#L5
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

/hold

holding to wait to see nothing breaks. @wking feel free to drop the hold as soon as aws and azure rehearsals go green.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

As soon as the setup container succeeds even

@abhinavdahiya
Copy link
Contributor

As soon as the setup container succeeds even

The change is for teardown container, so I would hope we wait for teardown to be green..

@wking wking mentioned this pull request Sep 18, 2019
Merged
@wking
Copy link
Member Author

wking commented Sep 18, 2019

All green, this Azure teardown and this AWS teardown were both fine.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit dbd7cfd into openshift:master Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 4 configmaps:

  • prow-job-cluster-launch-installer-src configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml

In response to this:

These came in with d00da5d (#3877), but the installer should be extracting the region from metadata.json.

/assign @abhinavdahiya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-regions-from-installer-teardown branch September 19, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wking @abhinavdahiya @openshift-ci-robot @smarterclayton @openshift-merge-robot