Skip to content

ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: 'set -e' in setup #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: 'set -e' in setup #5058

merged 1 commit into from
Sep 18, 2019

Conversation

wking
Copy link
Member

@wking wking commented Sep 17, 2019

As this script gets more complicated, start failing in internal commands instead of glibly marching on after one of them fails.

@wking
ci-operator/templates/openshift/installer/cluster-launch-installer-e2…
0a16dc5 
…e: 'set -e' in setup

As this script gets more complicated, start failing in internal
commands instead of glibly marching on after one of them fails.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2019
@wking
Copy link
Member Author

wking commented Sep 18, 2019

All green.

/assign @abhinavdahiya

@smarterclayton
Copy link
Contributor

The horror, were there any other places that need this that cargo culted?

@smarterclayton
Copy link
Contributor

/lgtm

but if you can do a follow up to look for others I would appreciate it

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d64416d into openshift:master Sep 18, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml

In response to this:

As this script gets more complicated, start failing in internal commands instead of glibly marching on after one of them fails.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Sep 18, 2019
Closed
@wking wking deleted the ipi-setup-set-e branch September 20, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@smarterclayton smarterclayton

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wking @smarterclayton @openshift-ci-robot @abhinavdahiya @openshift-merge-robot