-
Notifications
You must be signed in to change notification settings - Fork 1.9k
templates/openshift/installer: run Azure specific e2e tests #4098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates/openshift/installer: run Azure specific e2e tests #4098
Conversation
46929c4
to
9da254f
Compare
/test pj-rehearse |
/test core-valid |
depends on openshift/origin#23220 |
9da254f
to
ec57de9
Compare
/retest |
95ef15b
to
64933cf
Compare
/retest |
This fixes the type for test container where CLUSTER_TYPE shuold have been `azure4` Azure e2e tests require cloud provider config file for tests [1]. The tests fetch the cloud provider config from `openshift-config/cloud-provider-config` config map from the cluster to a temp file, and run the e2e tests using that file. [1]: https://github.com/kubernetes/kubernetes/blob/f0812288a94766c93cccfbea9daa1b0a02563e8f/test/e2e/framework/providers/azure/azure.go#L36-L38
64933cf
to
5a07839
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jcpowermac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhinavdahiya: Updated the following 4 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhinavdahiya: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This fixes the type for test container where CLUSTER_TYPE shuold have been
azure4
Azure e2e tests require cloud provider config file for tests [1]. The tests fetch the cloud provider config from
openshift-config/cloud-provider-config
config map from the cluster to a temp file, andrun the e2e tests using that file.
[1]: https://github.com/kubernetes/kubernetes/blob/f0812288a94766c93cccfbea9daa1b0a02563e8f/test/e2e/framework/providers/azure/azure.go#L36-L38
/cc @smarterclayton