Skip to content

templates/openshift/installer: run Azure specific e2e tests #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

abhinavdahiya
Copy link
Contributor

This fixes the type for test container where CLUSTER_TYPE shuold have been azure4

Azure e2e tests require cloud provider config file for tests [1]. The tests fetch the cloud provider config from openshift-config/cloud-provider-config config map from the cluster to a temp file, and
run the e2e tests using that file.
[1]: https://github.com/kubernetes/kubernetes/blob/f0812288a94766c93cccfbea9daa1b0a02563e8f/test/e2e/framework/providers/azure/azure.go#L36-L38

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 19, 2019
@droslean
Copy link
Member

/test pj-rehearse

@openshift-merge-robot
Copy link
Contributor

/test core-valid
/test core-dry

@abhinavdahiya
Copy link
Contributor Author

depends on openshift/origin#23220

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya abhinavdahiya force-pushed the fix_azure_e2e branch 2 times, most recently from 95ef15b to 64933cf Compare June 21, 2019 19:58
@abhinavdahiya
Copy link
Contributor Author

/retest

This fixes the type for test container where CLUSTER_TYPE shuold have been `azure4`

Azure e2e tests require cloud provider config file for tests [1]. The tests fetch the cloud provider config from `openshift-config/cloud-provider-config` config map from the cluster to a temp file, and
run the e2e tests using that file.
[1]: https://github.com/kubernetes/kubernetes/blob/f0812288a94766c93cccfbea9daa1b0a02563e8f/test/e2e/framework/providers/azure/azure.go#L36-L38
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f5ed31a into openshift:master Jun 24, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Updated the following 4 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml

In response to this:

This fixes the type for test container where CLUSTER_TYPE shuold have been azure4

Azure e2e tests require cloud provider config file for tests [1]. The tests fetch the cloud provider config from openshift-config/cloud-provider-config config map from the cluster to a temp file, and
run the e2e tests using that file.
[1]: https://github.com/kubernetes/kubernetes/blob/f0812288a94766c93cccfbea9daa1b0a02563e8f/test/e2e/framework/providers/azure/azure.go#L36-L38

/cc @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/fabric8-services/toolchain-operator/master/e2e 5a07839 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-azure/master/e2e-azure 5a07839 link /test pj-rehearse
ci/prow/pj-rehearse 5a07839 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants