Deploy support-operator into all CI clusters to report live data #3951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Verified secret was created safely, the upi/vsphere things are flakes. |
smarterclayton
added
lgtm
|
@smarterclayton: Updated the following 12 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jul 1, 2020
…step These have been part of the e2e test step since that step landed in a2fd8c3 (step-registry: add Origin E2E test step, 2020-01-31, openshift#6965). But pushing manifests is more of an install thing than a test thing. For example, if a user swaps in their own tests, we still want the cluster to push insights if their cluster profile includes the token). The logic I'm replacing was just handling the insights operator. To allow us to recycle the same logic for additional manifests, I've carved out generic handling for ${CLUSTER_PROFILE_DIR} and ${SHARED_DIR}. The day-2 naming avoids conflicts with the ipi/install step that is already consuming ${SHARED_DIR}/manifest_*.yml Glob expansion should have stable ordering; from POSIX [1]: If the pattern matches any existing filenames or pathnames, the pattern shall be replaced with those filenames and pathnames, sorted according to the collating sequence in effect in the current locale. Ideally we'd update the cluster profiles themselves to store the config in day-2-manifests-insights-live.yaml (via a core-services/ci-secret-bootstrap/_config.yaml edit?). But we can't do that until we've removed or ported the old-style templates under ci-operator/templates, so I'm leaving that off for now and keeping a HACK check to copy the current profile's file into the newly-expected target location. The previous logic also used an error-ignoring '|| true' since at least b887d20 (Deploy the insights secret for the support-operator in all templates, 2019-06-04, openshift#3951). That commit didn't motivate its use, so I'm dropping it here. If the step fails, figuring out the culprit should be pretty straightforward. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_13_03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin testing support-operator in CI by having all CI clusters push
to a specific insights account.