Skip to content

ci-operator/templates/openshift: Remove unnecessary exports for PULL_SECRET and similar #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci-operator/templates/openshift: Remove unnecessary exports for PULL_SECRET and similar #3586

wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Apr 24, 2019 •
edited
Loading

These are local variables; we don't need to leak them down into child processes. At least some of these were introduced in 4134347 (#2353). The motivation behind the old approach is not clear to me, but I suspect overly broad pattern-matching ;).

CC @crawford, @vrutkovs

@wking
ci-operator/templates/openshift: Remove unnecessary exports for PULL_…
a352564 
…SECRET and similar

These are local variables; we don't need to leak them down into child
processes.  At least some of these were introduced in 4134347 (Use
install-configs when invoking installer, 2018-12-10, openshift#2353).  The
motivation behind the old approach is not clear to me, but I suspect
overly broad pattern-matching ;).
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2019
@vrutkovs
Copy link
Member

/test pj-rehearse

vrutkovs
vrutkovs approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere a352564 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-rhel-scaleup a352564 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack a352564 link /test pj-rehearse
ci/prow/pj-rehearse a352564 link /test pj-rehearse
ci/prow/generated-dashboards a352564 link /test generated-dashboards
ci/build-farm/build01-dry a352564 link /test build01-dry
ci/prow/prow-config a352564 link /test prow-config
ci/prow/step-registry-shellcheck a352564 link /test step-registry-shellcheck
ci/prow/build-farm-consistency a352564 link /test build-farm-consistency

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

Stale PR, please adapt and reopen if still needed.

/close

@openshift-ci-robot
Copy link
Contributor

@petr-muller: Closed this PR.

In response to this:

Stale PR, please adapt and reopen if still needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@sdodson sdodson Awaiting requested review from sdodson

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @vrutkovs @openshift-ci-robot @petr-muller