Skip to content

ci-operator: Remove uneccessary ARTIFACT_DIR touches #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2019
Merged

ci-operator: Remove uneccessary ARTIFACT_DIR touches #3585

merged 1 commit into from
Apr 27, 2019

Conversation

wking
Copy link
Member

@wking wking commented Apr 24, 2019

This got pulled up into the env block for cluster-launch-installer-e2e.yaml and cluster-launch-installer-src.yaml in 43dde9e (#2469). That obsoleted the previous export in the src template's test script.

I'm also removing a number of existing e2e consumers that set this to the default value, since there's no need to do that.

CC @stevekuznetsov , since I'm touching jobs that belong to other teams.

@wking
ci-operator: Remove uneccessary ARTIFACT_DIR touches
ece4d5a 
This got pulled up into the 'env' block for
cluster-launch-installer-e2e.yaml and
cluster-launch-installer-src.yaml in 43dde9e (Set KUBE_SSH_BASTION
and KUBE_SSH_KEY_PATH in installer tests, 2018-12-23, openshift#2469).  That
obsoleted the previous export in the src template's test script.

I'm also removing a number of existing e2e consumers that set this to
the default value, since there's no need to do that.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-image-registry-operator/release-4.0/e2e-aws-operator ece4d5a link /test pj-rehearse
ci/prow/pj-rehearse ece4d5a link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4dd3f9c into openshift:master Apr 27, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 9 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-master.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-master.yaml
  • ci-operator-4.0-configs configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-release-4.0.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.0.yaml
  • ci-operator-4.0-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-image-registry-operator-release-4.0.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.0.yaml
  • job-config-4.0 configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-release-4.0-presubmits.yaml using file ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.0-presubmits.yaml
  • job-config-4.1 configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-release-4.1-presubmits.yaml using file ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.1-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-image-registry-operator-master.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-master.yaml
  • ci-operator-4.1-configs configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-release-4.1.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.1.yaml
  • ci-operator-4.1-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-image-registry-operator-release-4.1.yaml using file ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.1.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-cluster-image-registry-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-master-presubmits.yaml

In response to this:

This got pulled up into the env block for cluster-launch-installer-e2e.yaml and cluster-launch-installer-src.yaml in 43dde9e (#2469). That obsoleted the previous export in the src template's test script.

I'm also removing a number of existing e2e consumers that set this to the default value, since there's no need to do that.

CC @stevekuznetsov , since I'm touching jobs that belong to other teams.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the fewer_ARTIFACT_DIR_touches branch April 27, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@legionus legionus Awaiting requested review from legionus

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @openshift-ci-robot @stevekuznetsov @openshift-merge-robot