Skip to content

Allow regular folks to label something as GA #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

Allow regular folks to label something as GA #2978

merged 1 commit into from
Apr 24, 2019

Conversation

thekad
Copy link
Contributor

@thekad thekad commented Feb 28, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2019
@kwoodson
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2019
@droslean
Copy link
Member

/test correctly-sharded-config

@droslean
Copy link
Member

/approve
/hold

@thekad you still want this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, kwoodson, thekad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@thekad
Copy link
Contributor Author

thekad commented Apr 24, 2019

/hold cancel
@droslean yes, thanks!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit b4fe336 into openshift:master Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

@thekad: Updated the plugins configmap in namespace ci using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

@jim-minter @kwoodson PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller Awaiting requested review from petr-muller

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@kwoodson kwoodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thekad @kwoodson @droslean @openshift-ci-robot @openshift-merge-robot