ci-operator/step-registry/openshift/e2e/test: Background and wait for openshift-tests #17007
Conversation
… openshift-tests The end-to-end step originated without the background/wait pattern in a2fd8c3 (step-registry: add Origin E2E test step, 2020-01-31, openshift#6965). But as described in 4472ace (ci-operator/templates/openshift/installer: Restore backgrounded 'create cluster', 2019-01-23, openshift#2680), we want the background-and-wait pattern to make openshift-tests a child process that will receive TERMs via this step's existing 'trap' handler. openshift-tests can take hours, and when the step gets a TERM, we want to quickly pass that through to the slow children, so they exit, so the step can exit, so we have plenty of time for asset uploading and subsequent gather and teardown steps. That gives us the resources we need to figure out why the test was abnormally slow.
openshift-ci-robot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The end-to-end step originated without the background/wait pattern in a2fd8c3 (#6965). But as described in 4472ace (#2680), we want the background-and-wait pattern to make openshift-tests a child process that will receive
TERMs via this step's existingtraphandler. openshift-tests can take hours, and when the step gets aTERM, we want to quickly pass that through to the slow children, so they exit, so the step can exit, so we have plenty of time for asset uploading and subsequent gather and teardown steps. That gives us the resources we need to figure out why the test was abnormally slow.