Skip to content

ci-operator/step-registry/gather/aws-console: Add .txt for machine-sourced IDs #14396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wking
Copy link
Member

@wking wking commented Dec 16, 2020

Fixing a typo we've had since the step was born in 390d6be (#9743).

…urced IDs

Fixing a typo we've had since the step was born in 390d6be
(gather/aws/console: Add a step to gather console logs on AWS,
2020-06-17, openshift#9743).
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@Miciah
Copy link
Contributor

Miciah commented Dec 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ebda937 into openshift:master Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key gather-aws-console-commands.sh using file ci-operator/step-registry/gather/aws-console/gather-aws-console-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key gather-aws-console-commands.sh using file ci-operator/step-registry/gather/aws-console/gather-aws-console-commands.sh

In response to this:

Fixing a typo we've had since the step was born in 390d6be (#9743).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the gather-aws-console-machine-txt-fixup branch December 16, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants