ci-operator/step-registry/ipi/conf/gcp: Get region from Boskos lease #14324
Conversation
Like 7aa198b (ci-operator/step-registry/ipi/conf/azure: Get region from Boskos lease, 2020-10-14, openshift#12584), but for AWS. This sets us up for sharding GCP by region, if we ever need that (e.g. GCP has an outage in one region). I'm leaving ci-operator/templates alone; hopefully those will be gone soon. I've already updated ci-tools with openshift/ci-tools@00ebab17e1 (pkg/steps/clusterinstall/template: Get region from Boskos lease, 2020-12-11, openshift/ci-tools#1527). I still wish the end-to-end suite pulled the region out of the cluster itself, but until it does, lean on the Infrastructure status [1] like we've been doing for AWS since bf0a271 (AWS e2e provider should identify zone and master and multizone, 2019-01-05, openshift#2507). [1]: https://github.com/openshift/api/blob/164a2fb63b5f12918c439a5a0a768aa911bcad99/config/v1/types_infrastructure.go#L327-L328
openshift-ci-robot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
/retest |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Like 7aa198b (#12584), but for AWS. This sets us up for sharding GCP by region, if we ever need that (e.g. GCP has an outage in one region).
I'm leaving
ci-operator/templatesalone; hopefully those will be gone soon. I've already updated ci-tools with openshift/ci-tools@00ebab17e1 (openshift/ci-tools#1527).I still wish the end-to-end suite pulled the region out of the cluster itself, but until it does, lean on the Infrastructure status like we've been doing for AWS since bf0a271 (#2507).