Skip to content

use origin-release:golang-1.10 Dockerfile to build origin-release:bazel #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2018
Merged

use origin-release:golang-1.10 Dockerfile to build origin-release:bazel #1431

merged 1 commit into from
Sep 10, 2018

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 10, 2018

@smarterclayton @wking this is a lot of work to get bazel into an origin-release image. This should fix the build.

wking
wking reviewed Sep 10, 2018
View reviewed changes
projects/origin-release/bazel/Dockerfile Outdated
FROM docker.io/openshift/origin-release:golang-1.10
ENV VERSION=1.10.3 \
GOCACHE=/go/.cache \
GOARM=5 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set this? Are we doing anything on ARM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set this? Are we doing anything on ARM?

Ah, probably a copy/paste here. Is there a way we can DRY this up by depending on the golang-1.10 tag locally without going through the docker.io registry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I copied/pasted bc I wanted it to be exactly origin-release:golang-1.10 plus bazel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can set the build config parent image (the source from)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know.. I hate that CI is broken at my expense atm though... and this origin-release:bazel tag is most likely only required short-term..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ok will set that in bc..

@wking wking mentioned this pull request Sep 10, 2018
Merged
@sallyom sallyom force-pushed the fixup-origin-release-bazel-is branch from 3f07e48 to c250df9 Compare September 10, 2018 20:00
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2018
@wking
Copy link
Member

wking commented Sep 10, 2018

c250df9 looks good to my Prow-novice eyes ;).

@sallyom
Copy link
Contributor Author

sallyom commented Sep 10, 2018

@smarterclayton @wking that should do it.. this will fix the build error we are seeing in the IS release:bazel

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@openshift-merge-robot openshift-merge-robot merged commit 8eb5f6c into openshift:master Sep 10, 2018
@openshift-ci-robot
Copy link
Contributor

@sallyom: The following updates succeeded:

  • /usr/bin/make applyTemplate WHAT=projects/origin-release/pipeline.yaml
    
$ /usr/bin/make applyTemplate WHAT=projects/origin-release/pipeline.yaml
oc process -f projects/origin-release/pipeline.yaml | oc apply -f -
imagestream "origin-release" configured
buildconfig "origin-release-golang-1.8" configured
buildconfig "origin-release-golang-1.9" configured
buildconfig "origin-release-golang-1.10" configured
buildconfig "origin-release-golang-1.11" configured
buildconfig "origin-release-bazel" configured
buildconfig "origin-release-nodejs-8" configured
buildconfig "origin-release-nodejs-8-browser-tests" configured

In response to this:

@smarterclayton @wking this is a lot of work to get bazel into an origin-release image. This should fix the build.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@andfasano
agent: enable assisted ui (openshift#1431)
4befdca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sallyom @wking @smarterclayton @openshift-ci-robot @openshift-merge-robot