tools/populate-owners: Also populate ci-operator/config/{org}/{repo}/OWNERS #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OWNERS The old shell script used to do this, but I'd accidentally dropped the functionality in e1f993f (populate-owners: Also slurp OWNERS_ALIASES, 2018-08-25, openshift#1285).
With a fresh run of tools/populate-owners.
openshift-ci-robot
added
the
size/L
|
Oops, I'd mean to: /assign @stevekuznetsov |
|
/lgtm |
openshift-ci-robot
added
the
approved
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Adding the flag to support the last change in the operator, as we are deploying MetalLB here through the operator. In the new operator configuration the operator takes control of the ConfigMap, meaning if an external thing (like the e2e tests) changes the ConfigMap the Operator will reconcile it to what it thinks it should be - making the e2e tests useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old shell script used to do this, but I'd accidentally dropped the functionality in #1285.
/assign @Kargakis